* [PATCH] ext2: avoid unnecessary operation in ext2_error()
@ 2018-11-07 13:47 Chengguang Xu
2018-11-08 14:15 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2018-11-07 13:47 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, Chengguang Xu
If filesystem has already mounted as read-only, then we don't have
to do it again.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/ext2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index cb91baa4275d..5e2861b947a6 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -73,7 +73,7 @@ void ext2_error(struct super_block *sb, const char *function,
if (test_opt(sb, ERRORS_PANIC))
panic("EXT2-fs: panic from previous error\n");
- if (test_opt(sb, ERRORS_RO)) {
+ if (!sb_rdonly(sb) && test_opt(sb, ERRORS_RO)) {
ext2_msg(sb, KERN_CRIT,
"error: remounting filesystem read-only");
sb->s_flags |= SB_RDONLY;
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ext2: avoid unnecessary operation in ext2_error()
2018-11-07 13:47 [PATCH] ext2: avoid unnecessary operation in ext2_error() Chengguang Xu
@ 2018-11-08 14:15 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2018-11-08 14:15 UTC (permalink / raw)
To: Chengguang Xu; +Cc: jack, linux-ext4
On Wed 07-11-18 21:47:04, Chengguang Xu wrote:
> If filesystem has already mounted as read-only, then we don't have
> to do it again.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Makes sense. Thanks for the patch. I have added it to my tree.
Honza
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index cb91baa4275d..5e2861b947a6 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -73,7 +73,7 @@ void ext2_error(struct super_block *sb, const char *function,
>
> if (test_opt(sb, ERRORS_PANIC))
> panic("EXT2-fs: panic from previous error\n");
> - if (test_opt(sb, ERRORS_RO)) {
> + if (!sb_rdonly(sb) && test_opt(sb, ERRORS_RO)) {
> ext2_msg(sb, KERN_CRIT,
> "error: remounting filesystem read-only");
> sb->s_flags |= SB_RDONLY;
> --
> 2.17.2
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-08 23:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-07 13:47 [PATCH] ext2: avoid unnecessary operation in ext2_error() Chengguang Xu
2018-11-08 14:15 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).