From: Jan Kara <jack@suse.cz>
To: Chengguang Xu <cgxu519@gmx.com>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: change reusable parameter to true when calling mb_cache_entry_create()
Date: Thu, 15 Nov 2018 17:26:10 +0100 [thread overview]
Message-ID: <20181115162610.GA12786@quack2.suse.cz> (raw)
In-Reply-To: <20181115064008.21056-1-cgxu519@gmx.com>
On Thu 15-11-18 14:40:08, Chengguang Xu wrote:
> Reusable parameter of mb_cache_entry_create() is bool type,
> so it's better to set true instead of 1.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Applied after fixing the whitespace damage. Thanks.
Honza
> ---
> fs/ext2/xattr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 62d9a659a8ff..6bab2432b717 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -835,7 +835,8 @@ ext2_xattr_cache_insert(struct mb_cache *cache, struct buffer_head *bh)
> __u32 hash = le32_to_cpu(HDR(bh)->h_hash);
> int error;
>
> - error = mb_cache_entry_create(cache, GFP_NOFS, hash, bh->b_blocknr, 1);
> + error = mb_cache_entry_create(cache, GFP_NOFS, hash,
> + bh->b_blocknr,true);
> if (error) {
> if (error == -EBUSY) {
> ea_bdebug(bh, "already in cache (%d cache entries)",
> --
> 2.17.2
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2018-11-16 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 6:40 [PATCH] ext2: change reusable parameter to true when calling mb_cache_entry_create() Chengguang Xu
2018-11-15 16:26 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115162610.GA12786@quack2.suse.cz \
--to=jack@suse.cz \
--cc=cgxu519@gmx.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).