From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2scrub: fix systemd escaping again
Date: Thu, 15 Nov 2018 14:20:58 -0500 [thread overview]
Message-ID: <20181115192058.GE20617@thunk.org> (raw)
In-Reply-To: <20181105175946.GA4124@magnolia>
On Mon, Nov 05, 2018 at 09:59:46AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Apparently newer versions of systemd than the one on this author's
> laptop <cough> now complain about lack of (path) escaping in unit
> instance variable contents:
>
> # e2scrub_all
> Scrubbing /home...
> Invalid unit name "e2scrub@/home" was escaped as "e2scrub@-home"
> (maybe you should use systemd-escape?)
> Starting Online ext4 Metadata Check for /home...
>
> So change the escape_path_for_systemd function to escape paths
> unconditionally to make the warning go away.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2018-11-16 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 17:59 [PATCH] e2scrub: fix systemd escaping again Darrick J. Wong
2018-11-15 19:20 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115192058.GE20617@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).