From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH e2fsprogs 9/9] tune2fs: Prevent enabling encryption flag on encoding-aware fs
Date: Wed, 21 Nov 2018 00:03:01 -0500 [thread overview]
Message-ID: <20181121050301.GD26006@thunk.org> (raw)
In-Reply-To: <20181015211220.27370-10-krisman@collabora.co.uk>
On Mon, Oct 15, 2018 at 05:12:20PM -0400, Gabriel Krisman Bertazi wrote:
> The kernel will refuse to mount filesystems with the encryption and
> encoding features enabled at the same time. The encoding feature can
> only be set at mount time, so we can just prevent encryption from being
> set at a later time by tune2fs.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
This check also needs to be in mke2fs, right? I don't think I saw it
in your mke2fs patch.
- Ted
next prev parent reply other threads:[~2018-11-21 15:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 21:12 [PATCH e2fsprogs 0/9] Support encoding awareness and casefold Gabriel Krisman Bertazi
2018-10-15 21:12 ` [PATCH e2fsprogs 1/9] e2fsprogs: Add timestamp extension bits to superblock Gabriel Krisman Bertazi
2018-11-19 3:35 ` Theodore Y. Ts'o
2018-10-15 21:12 ` [PATCH e2fsprogs 2/9] e2fsprogs: Reserve feature bit and SB field bit for filename encoding Gabriel Krisman Bertazi
2018-11-19 4:15 ` Theodore Y. Ts'o
2018-10-15 21:12 ` [PATCH e2fsprogs 3/9] libe2p: Helpers for configuring the encoding superblock fields Gabriel Krisman Bertazi
2018-11-19 4:27 ` Theodore Y. Ts'o
2018-11-19 15:28 ` Gabriel Krisman Bertazi
2018-11-21 4:32 ` Theodore Y. Ts'o
2018-11-21 19:33 ` Gabriel Krisman Bertazi
2018-10-15 21:12 ` [PATCH e2fsprogs 4/9] mke2fs: Configure encoding during superblock initialization Gabriel Krisman Bertazi
2018-11-21 4:55 ` Theodore Y. Ts'o
2018-11-21 19:43 ` Gabriel Krisman Bertazi
2018-10-15 21:12 ` [PATCH e2fsprogs 5/9] chattr/lsattr: Support casefold attribute Gabriel Krisman Bertazi
2018-11-21 5:00 ` Theodore Y. Ts'o
2018-10-15 21:12 ` [PATCH e2fsprogs 6/9] lib/ext2fs: Implement NLS support Gabriel Krisman Bertazi
2018-11-21 5:01 ` Theodore Y. Ts'o
2018-11-21 19:44 ` Gabriel Krisman Bertazi
2018-10-15 21:12 ` [PATCH e2fsprogs 7/9] lib/ext2fs: Support encoding when calculating dx hashes Gabriel Krisman Bertazi
2018-11-21 5:10 ` Theodore Y. Ts'o
2018-10-15 21:12 ` [PATCH e2fsprogs 8/9] debugfs/htree: Support encoding when printing the file hash Gabriel Krisman Bertazi
2018-10-15 21:12 ` [PATCH e2fsprogs 9/9] tune2fs: Prevent enabling encryption flag on encoding-aware fs Gabriel Krisman Bertazi
2018-11-21 5:03 ` Theodore Y. Ts'o [this message]
2018-11-21 19:46 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121050301.GD26006@thunk.org \
--to=tytso@mit.edu \
--cc=krisman@collabora.co.uk \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).