From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: alexey.lyashkov@gmail.com
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] Fix panic with journal superblock flags printing.
Date: Wed, 21 Nov 2018 18:54:32 -0500 [thread overview]
Message-ID: <20181121235432.GE10588@thunk.org> (raw)
In-Reply-To: <20181119091650.81803-3-alexey.lyashkov@gmail.com>
The summary really isn't right; "panic" is something that kernels do,
not userspace programs.
> - if (dump_super) {
> + if (dump_all || dump_super) {
> e2p_list_journal_super(out_file, jsb_buffer,
> - current_fs->blocksize, 0);
> + 1024, 0);
This makes no sense to me. Why is hard-coding the expected blocksize
to be 1024 a good thing to do here?
- Ted
next prev parent reply other threads:[~2018-11-22 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 9:16 [PATCH 0/3] debugfs fixes alexey.lyashkov
2018-11-19 9:16 ` [PATCH 1/3] block number output fix alexey.lyashkov
2018-11-21 23:33 ` Theodore Y. Ts'o
2018-11-19 9:16 ` [PATCH 2/3] Fix panic with journal superblock flags printing alexey.lyashkov
2018-11-21 23:54 ` Theodore Y. Ts'o [this message]
2018-11-22 4:24 ` Alexey Lyashkov
2018-11-22 21:23 ` Theodore Y. Ts'o
2018-11-19 9:16 ` [PATCH 3/3] add support to check a journal checksum v1 while journal dump alexey.lyashkov
2018-11-22 0:07 ` Theodore Y. Ts'o
2018-11-22 5:08 ` Alexey Lyashkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121235432.GE10588@thunk.org \
--to=tytso@mit.edu \
--cc=alexey.lyashkov@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).