linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Jean-Christophe Guillain <jcguillain@sequans.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Metadata_csum is still enabled after trying to disable it.
Date: Wed, 21 Nov 2018 19:01:19 -0800	[thread overview]
Message-ID: <20181122030119.GA6778@magnolia> (raw)
In-Reply-To: <E1gPWbq-0006F7-IZ@eureka>

On Wed, Nov 21, 2018 at 06:48:18PM +0100, Jean-Christophe Guillain wrote:
> Hi,
> 
> I see a strange behaviour when playing with the metadata_csum parameter of ext4.
> (I use a Debian Stretch, with a kernel 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux)
> 
> How to reproduce :
> 
> * I enable metada checksum : OK
>     root@test# tune2fs -O metadata_csum /dev/my_vol
>     tune2fs 1.43.4 (31-Jan-2017)
>     Enabling checksums could take some time.
>     Proceed anyway (or wait 5 seconds) ? (y,N) y
> 
> * I check : Checksum enabled
>     root@test# tune2fs -l /dev/my_vol
>     tune2fs 1.43.4 (31-Jan-2017)
>     Filesystem volume name:   <none>
>     [...]
>     Journal backup:           inode blocks
>     Checksum type:            crc32c
>     Checksum:                 0xb0e3a180
> 
> * I change filesystem UUID : OK
>     root@test# tune2fs -U random /dev/my_vol
>     tune2fs 1.43.4 (31-Jan-2017)
>     Setting UUID on a checksummed filesystem could take some time.
>     Proceed anyway (or wait 5 seconds) ? (y,N) y
> 
> * I disable metadata checksum : OK
>     root@test# tune2fs -O ^metadata_csum /dev/my_vol
>     tune2fs 1.43.4 (31-Jan-2017)
>     Disabling checksums could take some time.
>     Proceed anyway (or wait 5 seconds) ? (y,N) y
> 
> * I change filesystem UUID : It looks like metada checksum still is enabled
>     root@test# tune2fs -U random /dev/my_vol
>     tune2fs 1.43.4 (31-Jan-2017)
>     Setting UUID on a checksummed filesystem could take some time.
>     Proceed anyway (or wait 5 seconds) ? (y,N) y
> 
> * I fsck the filesystem to see if it could fix this.
>     root@test# e2fsck -f /dev/my_vol
>     2fsck 1.43.4 (31-Jan-2017)
>     Pass 1: Checking inodes, blocks, and sizes
>     Pass 2: Checking directory structure
>     Pass 3: Checking directory connectivity
>     Pass 4: Checking reference counts
>     Pass 5: Checking group summary information
>     /dev/my_vol: 16303/3932160 files (0.9% non-contiguous), 1829950/15728640 blocks
> 
> * I check : metadata checksum looks like disabled
>     root@test# tune2fs -l /dev/my_vol tune2fs 1.43.4 (31-Jan-2017)
>     Filesystem volume name:   <none>
>     [...]
>     Journal backup:           inode blocks
> 
> * I change filesystem UUID : It looks like metada checksum still is enabled
>     root@test# tune2fs -U random /dev/my_vol
>     tune2fs 1.43.4 (31-Jan-2017)
>     Setting UUID on a checksummed filesystem could take some time.
>     Proceed anyway (or wait 5 seconds) ? (y,N) y
> 
> Is it a bug ?

Yes.

> How can I actually disable this parameter ?

I think you have to turn off the metadata_csum_seed feature, but tbh
tune2fs really shouldn't pester about !metadata_csum,metadata_csum_seed
filesystems...

--D

> Best regards,
> jC Guillain
> 
> 
> -- IMPORTANT NOTICE: 
> 
> The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> 

  reply	other threads:[~2018-11-22 13:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 17:48 Metadata_csum is still enabled after trying to disable it Jean-Christophe Guillain
2018-11-22  3:01 ` Darrick J. Wong [this message]
2018-11-24  3:48   ` Theodore Y. Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2018-11-23 15:25 Jean-Christophe Guillain
2018-11-26 13:51 Jean-Christophe Guillain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181122030119.GA6778@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=jcguillain@sequans.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).