* [PATCH] ext4: clean up indentation issues, remove extraneous tabs
@ 2018-11-23 16:30 Colin King
2018-11-27 9:28 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-11-23 16:30 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, linux-ext4
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are several lines that are indented too far, clean these
up by removing the tabs.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ext4/migrate.c | 12 ++++++------
fs/ext4/super.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index 61a9d1927817..5ae61cd8c5c9 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -535,22 +535,22 @@ int ext4_ext_migrate(struct inode *inode)
if (i_data[EXT4_IND_BLOCK]) {
retval = update_ind_extent_range(handle, tmp_inode,
le32_to_cpu(i_data[EXT4_IND_BLOCK]), &lb);
- if (retval)
- goto err_out;
+ if (retval)
+ goto err_out;
} else
lb.curr_block += max_entries;
if (i_data[EXT4_DIND_BLOCK]) {
retval = update_dind_extent_range(handle, tmp_inode,
le32_to_cpu(i_data[EXT4_DIND_BLOCK]), &lb);
- if (retval)
- goto err_out;
+ if (retval)
+ goto err_out;
} else
lb.curr_block += max_entries * max_entries;
if (i_data[EXT4_TIND_BLOCK]) {
retval = update_tind_extent_range(handle, tmp_inode,
le32_to_cpu(i_data[EXT4_TIND_BLOCK]), &lb);
- if (retval)
- goto err_out;
+ if (retval)
+ goto err_out;
}
/*
* Build the last extent
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 5603a4a1a864..15fc71398747 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1940,7 +1940,7 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
#ifdef CONFIG_FS_DAX
ext4_msg(sb, KERN_WARNING,
"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
- sbi->s_mount_opt |= m->mount_opt;
+ sbi->s_mount_opt |= m->mount_opt;
#else
ext4_msg(sb, KERN_INFO, "dax option not supported");
return -1;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: clean up indentation issues, remove extraneous tabs
2018-11-23 16:30 [PATCH] ext4: clean up indentation issues, remove extraneous tabs Colin King
@ 2018-11-27 9:28 ` Jan Kara
2018-12-04 5:17 ` Theodore Y. Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2018-11-27 9:28 UTC (permalink / raw)
To: Colin King
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, kernel-janitors,
linux-kernel
On Fri 23-11-18 16:30:43, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several lines that are indented too far, clean these
> up by removing the tabs.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/migrate.c | 12 ++++++------
> fs/ext4/super.c | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
> index 61a9d1927817..5ae61cd8c5c9 100644
> --- a/fs/ext4/migrate.c
> +++ b/fs/ext4/migrate.c
> @@ -535,22 +535,22 @@ int ext4_ext_migrate(struct inode *inode)
> if (i_data[EXT4_IND_BLOCK]) {
> retval = update_ind_extent_range(handle, tmp_inode,
> le32_to_cpu(i_data[EXT4_IND_BLOCK]), &lb);
> - if (retval)
> - goto err_out;
> + if (retval)
> + goto err_out;
> } else
> lb.curr_block += max_entries;
> if (i_data[EXT4_DIND_BLOCK]) {
> retval = update_dind_extent_range(handle, tmp_inode,
> le32_to_cpu(i_data[EXT4_DIND_BLOCK]), &lb);
> - if (retval)
> - goto err_out;
> + if (retval)
> + goto err_out;
> } else
> lb.curr_block += max_entries * max_entries;
> if (i_data[EXT4_TIND_BLOCK]) {
> retval = update_tind_extent_range(handle, tmp_inode,
> le32_to_cpu(i_data[EXT4_TIND_BLOCK]), &lb);
> - if (retval)
> - goto err_out;
> + if (retval)
> + goto err_out;
> }
> /*
> * Build the last extent
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 5603a4a1a864..15fc71398747 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1940,7 +1940,7 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
> #ifdef CONFIG_FS_DAX
> ext4_msg(sb, KERN_WARNING,
> "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
> - sbi->s_mount_opt |= m->mount_opt;
> + sbi->s_mount_opt |= m->mount_opt;
> #else
> ext4_msg(sb, KERN_INFO, "dax option not supported");
> return -1;
> --
> 2.19.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: clean up indentation issues, remove extraneous tabs
2018-11-27 9:28 ` Jan Kara
@ 2018-12-04 5:17 ` Theodore Y. Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2018-12-04 5:17 UTC (permalink / raw)
To: Jan Kara
Cc: Colin King, Andreas Dilger, linux-ext4, kernel-janitors,
linux-kernel
On Tue, Nov 27, 2018 at 10:28:36AM +0100, Jan Kara wrote:
> On Fri 23-11-18 16:30:43, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There are several lines that are indented too far, clean these
> > up by removing the tabs.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-04 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-23 16:30 [PATCH] ext4: clean up indentation issues, remove extraneous tabs Colin King
2018-11-27 9:28 ` Jan Kara
2018-12-04 5:17 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).