From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Chengguang Xu <cgxu519@gmx.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: remove redundant condition check
Date: Tue, 4 Dec 2018 00:25:27 -0500 [thread overview]
Message-ID: <20181204052527.GG4981@thunk.org> (raw)
In-Reply-To: <20181127094358.GE16301@quack2.suse.cz>
On Tue, Nov 27, 2018 at 10:43:58AM +0100, Jan Kara wrote:
> On Wed 14-11-18 07:24:48, Chengguang Xu wrote:
> > ext4_xattr_destroy_cache() can handle NULL pointer correctly,
> > so there is no need to check NULL pointer before calling
> > ext4_xattr_destroy_cache().
> >
> > Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2018-12-04 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 23:24 [PATCH] ext4: remove redundant condition check Chengguang Xu
2018-11-27 9:43 ` Jan Kara
2018-12-04 5:25 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204052527.GG4981@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=cgxu519@gmx.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).