From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: linux-ext4@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] e2fsprogs: Introduce script used to generate utf8data.h
Date: Sat, 8 Dec 2018 13:13:24 -0500 [thread overview]
Message-ID: <20181208181324.GC20708@thunk.org> (raw)
In-Reply-To: <20181203230428.28485-1-krisman@collabora.com>
On Mon, Dec 03, 2018 at 06:04:28PM -0500, Gabriel Krisman Bertazi wrote:
> The mkutf8data program was written by SGI for the kernel. We integrate
> it here, but it should be kept in sync with the kernel code, when
> applicable. The header generated by this script is also included in
> this repository, such that we don't have to carry the UCD files too.
> They are only necessary when the header has to be recreated (for
> instance, to update the Unicode version supported)
>
> The mkutf8data is not a dependency of utf8data.h because we don't want
> the utf8data.h rule to be called after a make clean that would remove
> mkutf8data. It is simpler to call it from inside the rule, and make
> sure we only trigger the utf8data.h rule if we really need to,
> particularly if we decide not to integrate the ucd files in the tree.
>
> The UCD files are not distributed along with this commit, but we add
> information on how to fetch them.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Thanks, applied, with one minor fixup:
> diff --git a/util/ucd/README b/util/ucd/README
> new file mode 100644
> index 000000000000..9fed514084b7
> --- /dev/null
> +++ b/util/ucd/README
...
> +md5sums
> +
> + 414436796cf097df55f798e1585448ee CaseFolding-11.0.0.txt
> + 6032a595fbb782694456491d86eecfac DerivedAge-11.0.0.txt
> + 3240997d671297ac754ab0d27577acf7 DerivedCombiningClass-11.0.0.txt
> + d41d8cd98f00b204e9800998ecf8427e DerivedCombiningClass.txt
^^^^^^^^^^^^^^^^^^^^^^^^^
This looks like a leftover, so I removed it.
- Ted
next prev parent reply other threads:[~2018-12-08 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 23:04 [PATCH] e2fsprogs: Introduce script used to generate utf8data.h Gabriel Krisman Bertazi
2018-12-08 18:13 ` Theodore Y. Ts'o [this message]
2018-12-09 20:55 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208181324.GC20708@thunk.org \
--to=tytso@mit.edu \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).