From: Jan Kara <jack@suse.cz>
To: Chengguang Xu <cgxu519@gmx.com>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 00/10] fix coding style for ext2 filesystem
Date: Wed, 12 Dec 2018 14:15:18 +0100 [thread overview]
Message-ID: <20181212131518.GE10902@quack2.suse.cz> (raw)
In-Reply-To: <20181113000448.16023-1-cgxu519@gmx.com>
On Tue 13-11-18 08:04:38, Chengguang Xu wrote:
> This patch set fixes some coding style warnings which are from
> checkpatch.pl.
>
> Detail warning/error messages are below:
>
> WARNING: function definition argument 'struct inode *' should
> also have an identifier name
>
> WARNING: space prohibited between function name and open
> parenthesis '('
>
> WARNING: line over 80 characters
>
> ERROR: "foo * bar" should be "foo *bar"
Thanks for the series! I had a look into the patches but I don't think
these whitespace fixes are really worth the churn. Sorry.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-12-12 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 0:04 [PATCH 00/10] fix coding style for ext2 filesystem Chengguang Xu
2018-11-13 0:04 ` [PATCH 01/10] ext2: fix coding style for acl.h Chengguang Xu
2018-11-13 0:04 ` [PATCH 02/10] ext2: fix coding style for balloc.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 03/10] ext2: fix coding style for dir.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 04/10] ext2: fix coding style for ext2.h Chengguang Xu
2018-11-13 0:04 ` [PATCH 05/10] ext2: fix coding style for inode.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 06/10] ext2: fix coding style for file.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 07/10] ext2: fix coding style for ialloc.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 08/10] ext2: fix coding style for namei.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 09/10] ext2: fix coding style for super.c Chengguang Xu
2018-11-13 0:04 ` [PATCH 10/10] ext2: fix coding style for xattr.c Chengguang Xu
2018-12-12 13:15 ` Jan Kara [this message]
2018-12-12 13:49 ` [PATCH 00/10] fix coding style for ext2 filesystem cgxu519
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212131518.GE10902@quack2.suse.cz \
--to=jack@suse.cz \
--cc=cgxu519@gmx.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).