linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: <linux-fstests@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Theodore Ts'o <tytso@mit.edu>, Liu Bo <obuil.liubo@gmail.com>
Subject: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034
Date: Wed, 26 Dec 2018 11:08:05 -0500	[thread overview]
Message-ID: <20181226160805.8987-1-tytso@mit.edu> (raw)

Also add a requirment that fallocate and fiemap is supported.
(Fallocate isn't the case when we are emulating ext3, for example.)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Liu Bo <obuil.liubo@gmail.com>
---
 tests/ext4/034 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/ext4/034 b/tests/ext4/034
index 5c34d0d9..f9e4bfaf 100755
--- a/tests/ext4/034
+++ b/tests/ext4/034
@@ -8,7 +8,7 @@
 # "-o dioread_nolock,nodelalloc" is used.
 #
 # The bug was fixed by commit
-# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
+# "ext4: make sure enough credits are reserved for dioread_nolock writes"
 #
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
@@ -41,6 +41,8 @@ _supported_os Linux
 _require_scratch
 _require_quota
 _require_nobody
+_require_xfs_io_command "falloc"
+_require_xfs_io_command "fiemap"
 _require_xfs_io_command "syncfs"
 
 echo "Format and mount"
-- 
2.19.1

             reply	other threads:[~2018-12-26 16:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 16:08 Theodore Ts'o [this message]
2018-12-29  5:08 ` [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034 Eryu Guan
2018-12-29 13:54   ` Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181226160805.8987-1-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fstests@mit.edu \
    --cc=obuil.liubo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).