[PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

[PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

[Theodore Ts'o]

Also add a requirment that fallocate and fiemap is supported.
(Fallocate isn't the case when we are emulating ext3, for example.)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Liu Bo <obuil.liubo@gmail.com>
---
 tests/ext4/034 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/ext4/034 b/tests/ext4/034
index 5c34d0d9..f9e4bfaf 100755
--- a/tests/ext4/034
+++ b/tests/ext4/034
@@ -8,7 +8,7 @@
 # "-o dioread_nolock,nodelalloc" is used.
 #
 # The bug was fixed by commit
-# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
+# "ext4: make sure enough credits are reserved for dioread_nolock writes"
 #
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
@@ -41,6 +41,8 @@ _supported_os Linux
 _require_scratch
 _require_quota
 _require_nobody
+_require_xfs_io_command "falloc"
+_require_xfs_io_command "fiemap"
 _require_xfs_io_command "syncfs"
 
 echo "Format and mount"
-- 
2.19.1

Re: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

[Eryu Guan]

On Wed, Dec 26, 2018 at 11:08:05AM -0500, Theodore Ts'o wrote:
> Also add a requirment that fallocate and fiemap is supported.
> (Fallocate isn't the case when we are emulating ext3, for example.)
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: Liu Bo <obuil.liubo@gmail.com>

Patch looks good, but I assume you meant to send it to
fstests@vger.kernel.org not linux-fstests@mit.edu :)

Thanks,
Eryu

> ---
>  tests/ext4/034 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/ext4/034 b/tests/ext4/034
> index 5c34d0d9..f9e4bfaf 100755
> --- a/tests/ext4/034
> +++ b/tests/ext4/034
> @@ -8,7 +8,7 @@
>  # "-o dioread_nolock,nodelalloc" is used.
>  #
>  # The bug was fixed by commit
> -# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
> +# "ext4: make sure enough credits are reserved for dioread_nolock writes"
>  #
>  seq=`basename $0`
>  seqres=$RESULT_DIR/$seq
> @@ -41,6 +41,8 @@ _supported_os Linux
>  _require_scratch
>  _require_quota
>  _require_nobody
> +_require_xfs_io_command "falloc"
> +_require_xfs_io_command "fiemap"
>  _require_xfs_io_command "syncfs"
>  
>  echo "Format and mount"
> -- 
> 2.19.1
> 

Re: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

[Theodore Y. Ts'o]

On Sat, Dec 29, 2018 at 01:08:46PM +0800, Eryu Guan wrote:
> On Wed, Dec 26, 2018 at 11:08:05AM -0500, Theodore Ts'o wrote:
> > Also add a requirment that fallocate and fiemap is supported.
> > (Fallocate isn't the case when we are emulating ext3, for example.)
> > 
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > Cc: Liu Bo <obuil.liubo@gmail.com>
> 
> Patch looks good, but I assume you meant to send it to
> fstests@vger.kernel.org not linux-fstests@mit.edu :)

Oops, yes, that'd be correct.

					- Ted