From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Nikolay Borisov <nborisov@suse.com>
Cc: <adilger.kernel@dilger.ca>, <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Replace opencoded i_writecount usage with inode_is_open_for_write
Date: Sun, 10 Feb 2019 23:07:12 -0500 [thread overview]
Message-ID: <20190211040712.GD23000@mit.edu> (raw)
In-Reply-To: <20181211082355.19841-1-nborisov@suse.com>
On Tue, Dec 11, 2018 at 10:23:55AM +0200, Nikolay Borisov wrote:
> There is a function which clearly conveys the objective of checking
> i_writecount. Additionally the usage in ext4_mb_initialize_context was
> wrong, since a node would have wrongfully been reported as writable if
> i_writecount had a negative value (MMAP_DENY_WRITE).
>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-02-11 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 8:23 [PATCH] ext4: Replace opencoded i_writecount usage with inode_is_open_for_write Nikolay Borisov
2019-01-03 12:06 ` Nikolay Borisov
2019-01-24 11:01 ` Nikolay Borisov
2019-01-30 1:23 ` Andreas Dilger
2019-02-10 10:47 ` Nikolay Borisov
2019-02-11 4:07 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211040712.GD23000@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).