From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: yangerkun <yangerkun@huawei.com>
Cc: <jack@suse.com>, <miaoxie@huawei.com>, <yi.zhang@huawei.com>,
<houtao1@huawei.com>, <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V2 1/4] ext4: fix check of inode in swap_inode_boot_loader
Date: Mon, 11 Feb 2019 00:02:28 -0500 [thread overview]
Message-ID: <20190211050228.GJ23000@mit.edu> (raw)
In-Reply-To: <20190122065823.67957-2-yangerkun@huawei.com>
On Tue, Jan 22, 2019 at 02:58:20PM +0800, yangerkun wrote:
> Before really do swap between inode and boot inode, something need to
> check to avoid invalid or not permitted operation, like does this inode
> has inline data. But the condition check should be protected by inode
> lock to avoid change while swapping. Also some other condition will not
> change between swapping, but there has no problem to do this under inode
> lock.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2019-02-11 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 6:58 [PATCH V2 0/4] fix bugs for ioctl EXT4_IOC_SWAP_BOOT yangerkun
2019-01-22 6:58 ` [PATCH V2 1/4] ext4: fix check of inode in swap_inode_boot_loader yangerkun
2019-02-11 5:02 ` Theodore Y. Ts'o [this message]
2019-01-22 6:58 ` [PATCH V2 2/4] ext4: cleanup pagecache before swap i_data yangerkun
2019-02-11 5:12 ` Theodore Y. Ts'o
2019-01-22 6:58 ` [PATCH V2 3/4] ext4: update quota information while swapping boot loader inode yangerkun
2019-02-11 5:16 ` Theodore Y. Ts'o
2019-01-22 6:58 ` [PATCH V2 4/4] ext4: add mask of ext4 flags to swap yangerkun
2019-02-11 6:01 ` Theodore Y. Ts'o
2019-01-31 11:43 ` [PATCH V2 0/4] fix bugs for ioctl EXT4_IOC_SWAP_BOOT yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211050228.GJ23000@mit.edu \
--to=tytso@mit.edu \
--cc=houtao1@huawei.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).