From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Liu Song <fishland@aliyun.com>, <jack@suse.com>,
<linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<liu.song11@zte.com.cn>
Subject: Re: [PATCH] jbd2: jbd2_get_transaction does not need to return a value
Date: Fri, 1 Mar 2019 00:39:47 -0500 [thread overview]
Message-ID: <20190301053947.GB7930@mit.edu> (raw)
In-Reply-To: <20190226163504.GA24711@quack2.suse.cz>
On Tue, Feb 26, 2019 at 05:35:04PM +0100, Jan Kara wrote:
> On Wed 27-02-19 00:07:27, Liu Song wrote:
> > In jbd2_get_transaction, a new transaction is initialized,
> > and set to the j_running_transaction. No need for a return
> > value, so remove it.
> > Also, adjust some comments to match the actual operation
> > of this function.
> >
> > Signed-off-by: Liu Song <liu.song11@zte.com.cn>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-03-01 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190226160728.38587-1-fishland@aliyun.com>
2019-02-26 16:35 ` [PATCH] jbd2: jbd2_get_transaction does not need to return a value Jan Kara
2019-03-01 5:39 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301053947.GB7930@mit.edu \
--to=tytso@mit.edu \
--cc=fishland@aliyun.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.song11@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).