From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Subject: [PATCH v2 2/2] ext4: Report real fs size after failed resize
Date: Tue, 5 Mar 2019 11:54:00 +0100 [thread overview]
Message-ID: <20190305105400.4960-2-lczerner@redhat.com> (raw)
In-Reply-To: <20190305105400.4960-1-lczerner@redhat.com>
Currently when the file system resize using ext4_resize_fs() fails it
will report into log that "resized filesystem to <requested block
count>". However this may not be true in the case of failure. Use the
current block count as returned by ext4_blocks_count() to report the
block count.
Additionally report to log that "error occurred during file system
resize"
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
v2: this is actually the first version
fs/ext4/resize.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 5f89c19043a2..939e91a8c88b 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -2079,6 +2079,9 @@ int ext4_resize_fs(struct super_block *sb, ext4_fsblk_t n_blocks_count)
free_flex_gd(flex_gd);
if (resize_inode != NULL)
iput(resize_inode);
- ext4_msg(sb, KERN_INFO, "resized filesystem to %llu", n_blocks_count);
+ if (err)
+ ext4_warning(sb, "error occurred during file system resize");
+ ext4_msg(sb, KERN_INFO, "resized filesystem to %llu",
+ ext4_blocks_count(es));
return err;
}
--
2.20.1
next prev parent reply other threads:[~2019-03-05 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 10:53 [PATCH v2 1/2] ext4: Add missing brelse() in add_new_gdb_meta_bg() Lukas Czerner
2019-03-05 10:54 ` Lukas Czerner [this message]
2019-03-15 4:23 ` [PATCH v2 2/2] ext4: Report real fs size after failed resize Theodore Ts'o
2019-03-15 8:43 ` Lukas Czerner
2019-03-15 4:18 ` [PATCH v2 1/2] ext4: Add missing brelse() in add_new_gdb_meta_bg() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305105400.4960-2-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).