From: Lukas Czerner <lczerner@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ext4: Report real fs size after failed resize
Date: Fri, 15 Mar 2019 09:43:43 +0100 [thread overview]
Message-ID: <20190315084343.odt3mug7ffb6pwno@work> (raw)
In-Reply-To: <20190315042357.GH11334@mit.edu>
On Fri, Mar 15, 2019 at 12:23:58AM -0400, Theodore Ts'o wrote:
> On Tue, Mar 05, 2019 at 11:54:00AM +0100, Lukas Czerner wrote:
> > Currently when the file system resize using ext4_resize_fs() fails it
> > will report into log that "resized filesystem to <requested block
> > count>". However this may not be true in the case of failure. Use the
> > current block count as returned by ext4_blocks_count() to report the
> > block count.
> > Additionally report to log that "error occurred during file system
> > resize"
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>
> Thanks, applied with one minor change. In call to ext4_warning(), I
> changed it to include error code so the warning message will be more
> useful:
>
> > + if (err)
> > + ext4_warning(sb, "error occurred during file system resize");
>
> is now
>
> + if (err)
> + ext4_warning(sb, "error (%d) occurred during "
> + "file system resize", err);
Yeah, that's better.
Thanks!
-Lukas
>
> - Ted
next prev parent reply other threads:[~2019-03-15 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 10:53 [PATCH v2 1/2] ext4: Add missing brelse() in add_new_gdb_meta_bg() Lukas Czerner
2019-03-05 10:54 ` [PATCH v2 2/2] ext4: Report real fs size after failed resize Lukas Czerner
2019-03-15 4:23 ` Theodore Ts'o
2019-03-15 8:43 ` Lukas Czerner [this message]
2019-03-15 4:18 ` [PATCH v2 1/2] ext4: Add missing brelse() in add_new_gdb_meta_bg() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315084343.odt3mug7ffb6pwno@work \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox