From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2DEC282DC for ; Sun, 7 Apr 2019 02:14:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2C4620663 for ; Sun, 7 Apr 2019 02:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbfDGCOD (ORCPT ); Sat, 6 Apr 2019 22:14:03 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:49766 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726184AbfDGCOD (ORCPT ); Sat, 6 Apr 2019 22:14:03 -0400 Received: from callcc.thunk.org (225.sub-174-209-4.myvzw.com [174.209.4.225]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x372Dltg018865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 6 Apr 2019 22:13:50 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id A69BD421A0D; Sat, 6 Apr 2019 18:21:25 -0400 (EDT) Date: Sat, 6 Apr 2019 18:21:25 -0400 From: "Theodore Ts'o" To: Liu Song Cc: jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, liu.song11@zte.com.cn Subject: Re: [PATCH v2] jbd2: remove repeated assignments in __jbd2_log_wait_for_space Message-ID: <20190406222125.GD18897@mit.edu> Mail-Followup-To: Theodore Ts'o , Liu Song , jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, liu.song11@zte.com.cn References: <20190328145635.2540-1-fishland@aliyun.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328145635.2540-1-fishland@aliyun.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Mar 28, 2019 at 10:56:35PM +0800, Liu Song wrote: > From: Liu Song > > At the beginning, nblocks has been assigned. There is no need > to repeat the assignment in the while loop, and remove it. > > Signed-off-by: Liu Song > Reviewed-by: Jan Kara Thanks, applied. - Ted