* [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN()
@ 2019-03-19 20:38 Eric Biggers
2019-03-29 14:48 ` Jan Kara
2019-04-06 22:53 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2019-03-19 20:38 UTC (permalink / raw)
To: linux-ext4
From: Eric Biggers <ebiggers@google.com>
The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(),
which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's
crypto engine") but the comment was accidentally left in place. Since
ext4_encrypted_inode() has now been removed, just remove the comment.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/ext4/ext4.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 82ffdacdc7fac..2a2e6ed9aab4f 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1592,9 +1592,6 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
#define EXT4_SB(sb) (sb)
#endif
-/*
- * Returns true if the inode is inode is encrypted
- */
#define NEXT_ORPHAN(inode) EXT4_I(inode)->i_dtime
/*
--
2.21.0.225.g810b269d1ac-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN()
2019-03-19 20:38 [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN() Eric Biggers
@ 2019-03-29 14:48 ` Jan Kara
2019-04-06 22:53 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2019-03-29 14:48 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-ext4
On Tue 19-03-19 13:38:18, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(),
> which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's
> crypto engine") but the comment was accidentally left in place. Since
> ext4_encrypted_inode() has now been removed, just remove the comment.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/ext4.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 82ffdacdc7fac..2a2e6ed9aab4f 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1592,9 +1592,6 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
> #define EXT4_SB(sb) (sb)
> #endif
>
> -/*
> - * Returns true if the inode is inode is encrypted
> - */
> #define NEXT_ORPHAN(inode) EXT4_I(inode)->i_dtime
>
> /*
> --
> 2.21.0.225.g810b269d1ac-goog
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN()
2019-03-19 20:38 [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN() Eric Biggers
2019-03-29 14:48 ` Jan Kara
@ 2019-04-06 22:53 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2019-04-06 22:53 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-ext4
On Tue, Mar 19, 2019 at 01:38:18PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(),
> which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's
> crypto engine") but the comment was accidentally left in place. Since
> ext4_encrypted_inode() has now been removed, just remove the comment.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-07 2:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-19 20:38 [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN() Eric Biggers
2019-03-29 14:48 ` Jan Kara
2019-04-06 22:53 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).