From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0A83C10F13 for ; Tue, 16 Apr 2019 22:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79B692173C for ; Tue, 16 Apr 2019 22:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbfDPWiH (ORCPT ); Tue, 16 Apr 2019 18:38:07 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35484 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727057AbfDPWiG (ORCPT ); Tue, 16 Apr 2019 18:38:06 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-109.corp.google.com [104.133.0.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x3GMc0Wn021537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2019 18:38:01 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 76A73420497; Tue, 16 Apr 2019 18:38:00 -0400 (EDT) Date: Tue, 16 Apr 2019 18:38:00 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH] fscrypt: drop inode argument from fscrypt_get_ctx() Message-ID: <20190416223800.GA4053@mit.edu> References: <20190318172333.239937-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318172333.239937-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Mar 18, 2019 at 10:23:33AM -0700, Eric Biggers wrote: > From: Eric Biggers > > The only reason the inode is being passed to fscrypt_get_ctx() is to > verify that the encryption key is available. However, all callers > already ensure this because if we get as far as trying to do I/O to an > encrypted file without the key, there's already a bug. > > Therefore, remove this unnecessary argument. > > Signed-off-by: Eric Biggers Looks good, applied. - Ted