* [PATCH] libext2fs: remove unused variable 'old_flags'
@ 2019-04-22 21:11 Eric Biggers
2019-04-29 0:38 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2019-04-22 21:11 UTC (permalink / raw)
To: linux-ext4
From: Eric Biggers <ebiggers@google.com>
In ext2fs_write_inode2(), the 'old_flags' variable is never used.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
lib/ext2fs/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/ext2fs/inode.c b/lib/ext2fs/inode.c
index 2a4be739..75df418d 100644
--- a/lib/ext2fs/inode.c
+++ b/lib/ext2fs/inode.c
@@ -903,7 +903,6 @@ errcode_t ext2fs_write_inode2(ext2_filsys fs, ext2_ino_t ino,
return retval;
if (bufsize < length) {
- int old_flags = fs->flags;
retval = ext2fs_read_inode2(fs, ino,
(struct ext2_inode *)w_inode,
length, READ_INODE_NOCSUM);
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libext2fs: remove unused variable 'old_flags'
2019-04-22 21:11 [PATCH] libext2fs: remove unused variable 'old_flags' Eric Biggers
@ 2019-04-29 0:38 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2019-04-29 0:38 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-ext4
On Mon, Apr 22, 2019 at 02:11:36PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> In ext2fs_write_inode2(), the 'old_flags' variable is never used.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-29 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-22 21:11 [PATCH] libext2fs: remove unused variable 'old_flags' Eric Biggers
2019-04-29 0:38 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).