* [PATCH] ext4: Actually request zeroing of inode table after grow
@ 2019-04-22 8:23 Kirill Tkhai
2019-04-25 17:23 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Kirill Tkhai @ 2019-04-22 8:23 UTC (permalink / raw)
To: tytso, jack, adilger.kernel, ktkhai, linux-ext4
It is never possible, that number of block groups decreases,
since only online grow is supported.
But after a growing occured, we have to zero inode tables
for just created new block groups.
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index bab3da4f1e0d..20faa6a69238 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -978,7 +978,7 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
if (err == 0)
err = err2;
mnt_drop_write_file(filp);
- if (!err && (o_group > EXT4_SB(sb)->s_groups_count) &&
+ if (!err && (o_group < EXT4_SB(sb)->s_groups_count) &&
ext4_has_group_desc_csum(sb) &&
test_opt(sb, INIT_INODE_TABLE))
err = ext4_register_li_request(sb, o_group);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: Actually request zeroing of inode table after grow
2019-04-22 8:23 [PATCH] ext4: Actually request zeroing of inode table after grow Kirill Tkhai
@ 2019-04-25 17:23 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2019-04-25 17:23 UTC (permalink / raw)
To: Kirill Tkhai; +Cc: jack, adilger.kernel, linux-ext4
On Mon, Apr 22, 2019 at 11:23:20AM +0300, Kirill Tkhai wrote:
> It is never possible, that number of block groups decreases,
> since only online grow is supported.
>
> But after a growing occured, we have to zero inode tables
> for just created new block groups.
>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-25 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-22 8:23 [PATCH] ext4: Actually request zeroing of inode table after grow Kirill Tkhai
2019-04-25 17:23 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).