From: "Theodore Ts'o" <tytso@mit.edu>
To: Artem Blagodarenko <artem.blagodarenko@gmail.com>
Cc: linux-ext4@vger.kernel.org, alexey.lyashkov@gmail.com,
Alexey Lyashkov <c17817@cray.com>
Subject: Re: [PATCH] e2fsck: Do not to be quiet if verbose option used.
Date: Sun, 28 Apr 2019 19:38:47 -0400 [thread overview]
Message-ID: <20190428233847.GA31999@mit.edu> (raw)
In-Reply-To: <20190426130913.9288-1-c17828@cray.com>
On Fri, Apr 26, 2019 at 04:09:13PM +0300, Artem Blagodarenko wrote:
> From: Alexey Lyashkov <c17817@cray.com>
>
> e2fsck don't print a message if 'p' option used and error can be fixed without
> user assistance, but 'v' option asks to be more verbose, so user expect to
> see any output. But not.
> Fix this, by avoid message suppress with verbose option used.
>
> Change-Id: I358e9b04e44dd33fdb124c5663b2df0bf54ce370
> Signed-off-by: Alexey Lyashkov <c17817@cray.com>
> Cray-bug-id: LUS-6890
I need to understand the use case of what you are trying to do here.
The preen and verbose options were never intended to be mixed and this
patch changes what the verbose flag does at a fairly fundamental
level. I'm not sure the results will be correct and they will almost
certainly be surprising.
So (a) what is the user trying to do, and (b) what does the user want
to be trying to do? Preen was intended to be used as part of the boot
process, when multiple e2fsck's would be running in parallel, and so
you don't *want* much in the way of verbosity.
- Ted
next prev parent reply other threads:[~2019-04-28 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 13:09 [PATCH] e2fsck: Do not to be quiet if verbose option used Artem Blagodarenko
2019-04-28 23:38 ` Theodore Ts'o [this message]
2019-04-29 4:16 ` Alexey Lyashkov
2019-05-04 21:49 ` Theodore Ts'o
2019-05-04 22:04 ` Alexey Lyashkov
2019-05-05 4:12 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428233847.GA31999@mit.edu \
--to=tytso@mit.edu \
--cc=alexey.lyashkov@gmail.com \
--cc=artem.blagodarenko@gmail.com \
--cc=c17817@cray.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).