From: "Theodore Ts'o" <tytso@mit.edu>
To: Debabrata Banerjee <dbanerje@akamai.com>
Cc: Jan Kara <jack@suse.cz>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org,
Dmitry Monakhov <dmonakhov@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ext4: bad mount opts in no journal mode
Date: Tue, 30 Apr 2019 23:11:25 -0400 [thread overview]
Message-ID: <20190501031125.GC5377@mit.edu> (raw)
In-Reply-To: <20190429173158.1463-1-dbanerje@akamai.com>
On Mon, Apr 29, 2019 at 01:31:58PM -0400, Debabrata Banerjee wrote:
> Fixes:
> commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal")
>
> Instead of removing EXT4_MOUNT_JOURNAL_CHECKSUM from s_def_mount_opt as
> I assume was intended, all other options were blown away leading to
> _ext4_show_options() output being incorrect.
>
> Signed-off-by: Debabrata Banerjee <dbanerje@akamai.com>
Thanks, applied. Note that the Fixes line should like this:
Fixes: 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal")
... and be placed along with the Signed-off-by: headers.
- Ted
prev parent reply other threads:[~2019-05-01 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 17:31 [PATCH v2] ext4: bad mount opts in no journal mode Debabrata Banerjee
2019-04-29 21:11 ` Jan Kara
2019-05-01 3:11 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501031125.GC5377@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dbanerje@akamai.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).