From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06264C04A6B for ; Sun, 12 May 2019 12:58:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B97272133D for ; Sun, 12 May 2019 12:58:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MQcIPN1r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbfELM60 (ORCPT ); Sun, 12 May 2019 08:58:26 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37776 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbfELM6Z (ORCPT ); Sun, 12 May 2019 08:58:25 -0400 Received: by mail-pf1-f195.google.com with SMTP id g3so5684037pfi.4; Sun, 12 May 2019 05:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oNs3GlTxBq+wEh4KcvAaZtsqfVlm+piHZsRKYTXDtaM=; b=MQcIPN1rGMerMldIo0WT/AcPN3hfMWURZMjRQWQqnpFdvODW1yv08IanQ2MSNPk+++ JygyUp2EUts/X/M7kCLGDIHYP0pRkMsXs96f94Fdtxd842fuEhpObW/KwUZRWcImfL0t QfKxJfGMUZEXu48aSUm/ihfSbAnWlfG62dQ0yg+4WlKZeFO8ubs0qacul5WEm445NHBI rJmBPLJPh3G7Mqd2G0Q0lH/7rAyy2sxqJocoMvoV1b3JWozkseh8Sb66NkSG4cCKGi0R tKZKHAebnXNF2RFMrAL232qH3XrcNdpFe0qx8fZSU8hGaKTYUMH21y84w5O5T/fu84Yn l1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oNs3GlTxBq+wEh4KcvAaZtsqfVlm+piHZsRKYTXDtaM=; b=dWtxL5KnlgQOshSBda+M8cE/My9EAilgKbK40vnGlFxEu2BuT+yoUPRRLJRLs5L6wD 7ZVuU/i7Pl4M2UIkbHwhWqw8N/Mn2IO/AMClDvgXyoes1My5/CyNIFweVKpoItTvwoUe 7CqlJmxLVk9LgZlP5jn/nS4RHvaCykFpLz6TZ1yXZwEo8dUaYE5nRgvZ55dIDFIYFOv3 ECLTx5t5LuZER/Aql1iK7Cdu92a7S8s2nuVesObnjKdiyS8Cn9RYs14O6ao4GaHf9nS8 qdRHiptAxj+8GId9NOz+Am7w9PWev/2iWBOt2NZUxoa/5S/zFDn+41di7zKCNMNfauhd QLpA== X-Gm-Message-State: APjAAAW+J6lGcu90If0XGMUGZEDPQPRlpZ0DhAJk36IB7U3Lrry7WdbG 3ad2K3PaX0ZCW9BEkonLs7Q= X-Google-Smtp-Source: APXvYqz7tlS8/nL+68GCANaJ6ctVd2C3FQKn+3gO+yNnsEpZmKiQjmp+IQ2aDpjzBlMYvxLF39TbJA== X-Received: by 2002:a63:c046:: with SMTP id z6mr25864274pgi.387.1557665904870; Sun, 12 May 2019 05:58:24 -0700 (PDT) Received: from localhost ([128.199.137.77]) by smtp.gmail.com with ESMTPSA id m8sm13152085pgn.59.2019.05.12.05.58.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 May 2019 05:58:23 -0700 (PDT) Date: Sun, 12 May 2019 20:58:16 +0800 From: Eryu Guan To: Eric Biggers Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [RFC PATCH 0/7] xfstests: verify fscrypt-encrypted contents and filenames Message-ID: <20190512125816.GK15846@desktop> References: <20190426204153.101861-1-ebiggers@kernel.org> <20190506155721.GB661@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190506155721.GB661@sol.localdomain> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, May 06, 2019 at 08:57:22AM -0700, Eric Biggers wrote: > On Fri, Apr 26, 2019 at 01:41:46PM -0700, Eric Biggers wrote: > > Hello, > > > > This series adds xfstests which verify that encrypted contents and > > filenames on ext4 and f2fs are actually correct, i.e. that the > > encryption uses the correct algorithms, keys, IVs, and padding amounts. > > The new tests work by creating encrypted files, unmounting the > > filesystem, reading the ciphertext from disk using dd and debugfs or > > dump.f2fs, and then comparing it against ciphertext computed > > independently by a new test program that implements the same algorithms. > > > > These tests are important because: > > > > - The whole point of file encryption is that the files are actually > > encrypted correctly on-disk. Except for generic/399, current xfstests > > only tests the filesystem semantics, not the actual encryption. > > generic/399 only tests for incompressibility of encrypted file > > contents using one particular encryption setting, which isn't much. > > > > - fscrypt now supports 4 main combinations of encryption settings, > > rather than 1 as it did originally. This may be doubled to 8 soon > > (https://patchwork.kernel.org/patch/10908153/). We should test all > > settings. And without tests, even if the initial implementation is > > correct, breakage in one specific setting could go undetected. > > > > - Though Linux's crypto API has self-tests, these only test the > > algorithms themselves, not how they are used, e.g. by fscrypt. > > > > Patch 1 is a cleanup patch. Patches 2-4 add the common helpers for > > ciphertext verification tests. Patches 5-7 add the actual tests. > > > > These tests require e2fsprogs and f2fs-tools patches I recently sent out > > to fix printing encrypted filenames. So, this series might not be > > suitable for merging into mainline xfstests until those patches are > > applied. Regardless, comments are appreciated. The needed patches are: > > > > debugfs: avoid ambiguity when printing filenames (https://marc.info/?l=linux-ext4&m=155596495624232&w=2) > > f2fs-tools: improve filename printing (https://sourceforge.net/p/linux-f2fs/mailman/message/36648641/) > > > > This series can also be retrieved from git at > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git > > branch "ciphertext-verification". > > > > I also have patches on top of this series which verify the ciphertext > > produced from v2 encryption policies, which are proposed by my kernel > > patch series "fscrypt: key management improvements" > > (https://patchwork.kernel.org/cover/10908107/). v2 encryption policies > > will use a different key derivation function, and thus their ciphertext > > will be different. These additional patches can be found at branch > > "fscrypt-key-mgmt-improvements" of my git repo above. But I've arranged > > things such that this shorter series can potentially be applied earlier, > > to test what's in the kernel now. > > > > Eric Biggers (7): > > common/encrypt: introduce helpers for set_encpolicy and get_encpolicy > > fscrypt-crypt-util: add utility for reproducing fscrypt encrypted data > > common/encrypt: support requiring other encryption settings > > common/encrypt: add helper for ciphertext verification tests > > generic: verify ciphertext of v1 encryption policies with AES-256 > > generic: verify ciphertext of v1 encryption policies with AES-128 > > generic: verify ciphertext of v1 encryption policies with Adiantum > > > > .gitignore | 1 + > > common/encrypt | 482 ++++++++++- > > src/Makefile | 3 +- > > src/fscrypt-crypt-util.c | 1645 ++++++++++++++++++++++++++++++++++++++ > > tests/ext4/024 | 3 +- > > tests/generic/395 | 28 +- > > tests/generic/395.out | 2 +- > > tests/generic/396 | 15 +- > > tests/generic/397 | 3 +- > > tests/generic/398 | 5 +- > > tests/generic/399 | 3 +- > > tests/generic/419 | 3 +- > > tests/generic/421 | 3 +- > > tests/generic/429 | 3 +- > > tests/generic/435 | 3 +- > > tests/generic/440 | 5 +- > > tests/generic/700 | 41 + > > tests/generic/700.out | 5 + > > tests/generic/701 | 41 + > > tests/generic/701.out | 5 + > > tests/generic/702 | 43 + > > tests/generic/702.out | 10 + > > tests/generic/group | 3 + > > 23 files changed, 2308 insertions(+), 47 deletions(-) > > create mode 100644 src/fscrypt-crypt-util.c > > create mode 100755 tests/generic/700 > > create mode 100644 tests/generic/700.out > > create mode 100755 tests/generic/701 > > create mode 100644 tests/generic/701.out > > create mode 100755 tests/generic/702 > > create mode 100644 tests/generic/702.out > > > > -- > > 2.21.0.593.g511ec345e18-goog > > > > Any comments on this? Sorry for the late review, I went through the patches and they look fine to me over all from fstests perspective, I replied a few minor issues to individual patches. It'd be great if ext4 and/or f2fs folks could help review the tests as well. Thanks, Eryu > > FYI, the e2fsprogs patch that these tests need was applied. > > I'm still waiting for the f2fs-tools patch. > > - Eric