From: "Theodore Ts'o" <tytso@mit.edu>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>, Shuah Khan <shuah@kernel.org>,
patches@kernelci.org,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
lkft-triage@lists.linaro.org,
linux- stable <stable@vger.kernel.org>,
linux-ext4@vger.kernel.org,
Arthur Marsh <arthur.marsh@internode.on.net>,
Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: ext4 regression (was Re: [PATCH 4.19 000/105] 4.19.45-stable review)
Date: Tue, 21 May 2019 12:21:42 -0400 [thread overview]
Message-ID: <20190521162142.GA2591@mit.edu> (raw)
In-Reply-To: <CA+G9fYveeg_FMsL31aunJ2A9XLYk908Y1nSFw4kwkFk3h3uEiA@mail.gmail.com>
On Tue, May 21, 2019 at 03:58:15PM +0530, Naresh Kamboju wrote:
> > Ted, any ideas here? Should I drop this from the stable trees, and you
> > revert it from Linus's? Or something else?
It's safe to drop this from the stable trees while we investigate. It
was always borderline for stable anyway. (See below).
> >
> > Note, I do also have 170417c8c7bb ("ext4: fix block validity checks for
> > journal inodes using indirect blocks") in the trees, which was supposed
> > to fix the problem with this patch, am I missing another one as well?
>
> FYI,
> I have applied fix patch 170417c8c7bb ("ext4: fix block validity checks for
> journal inodes using indirect blocks") but did not fix this problem.
Hmm... are you _sure_? This bug was reported to me versus the
mainline, and the person who reported it confirmed that it did fix the
problem, he was seeing, and the symptoms are identical to yours. Can
you double check, please? I can't reproduce it either with that patch applied.
> > (side note, it was mean not to mark 170417c8c7bb for stable, when the
> > patch it was fixing was marked for stable, I'm lucky I caught it...)
Sorry, I had forgotten that I had marked 345c0dbf3a30 for stable;
that's why I didn't mark 170417c8c7bb for stable. 345c0dbf3a30 fixes
a crash triggered by a specially crafted (corrupted) file system, and
I had thought I had decided it wasn't important enough for stable; I
think what happened is I shrugged and said, "oh well, Sasha's
automated ML system is going to pick it for stable anyway, so I might
just mark it for stable anyway" --- and I forgot I had landed that
way.
- Ted
next prev parent reply other threads:[~2019-05-21 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190520115247.060821231@linuxfoundation.org>
2019-05-20 22:23 ` [PATCH 4.19 000/105] 4.19.45-stable review Dan Rue
2019-05-21 8:59 ` Greg Kroah-Hartman
2019-05-21 9:28 ` Naresh Kamboju
2019-05-21 9:38 ` ext4 regression (was Re: [PATCH 4.19 000/105] 4.19.45-stable review) Greg Kroah-Hartman
2019-05-21 10:28 ` Naresh Kamboju
2019-05-21 16:21 ` Theodore Ts'o [this message]
2019-05-21 16:30 ` Greg Kroah-Hartman
2019-05-21 16:44 ` Greg Kroah-Hartman
2019-05-21 17:57 ` Naresh Kamboju
2019-05-22 5:05 ` Theodore Ts'o
2019-05-22 10:20 ` Naresh Kamboju
2019-05-21 15:02 ` Dan Rue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521162142.GA2591@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=arthur.marsh@internode.on.net \
--cc=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=patches@kernelci.org \
--cc=richard.weinberger@gmail.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).