From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck: handle verity files in scan_extent_node()
Date: Fri, 24 May 2019 00:33:44 -0400 [thread overview]
Message-ID: <20190524043344.GF2532@mit.edu> (raw)
In-Reply-To: <20190523153033.22487-1-ebiggers@kernel.org>
On Thu, May 23, 2019 at 08:30:33AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Don't report PR_1_EXTENT_END_OUT_OF_BOUNDS on verity files during
> scan_extent_node(), since they will have blocks stored past i_size.
>
> This was missed during the earlier fix because this check only triggers
> if the inode has enough extents to need at least one extent index node.
>
> This bug is causing one of the fs-verity xfstests to fail with the
> reworked fs-verity patchset.
>
> Fixes: 3baafde6a8ae ("e2fsck: allow verity files to have initialized blocks past i_size")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
Could you supply a small (~200k) file system with a verity-protected
file so we can add a regression test? Many thanks!!
- Ted
prev parent reply other threads:[~2019-05-24 4:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 15:30 [PATCH] e2fsck: handle verity files in scan_extent_node() Eric Biggers
2019-05-24 4:33 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524043344.GF2532@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).