From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CBEC072B5 for ; Fri, 24 May 2019 04:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B97F2168B for ; Fri, 24 May 2019 04:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725917AbfEXEdv (ORCPT ); Fri, 24 May 2019 00:33:51 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40858 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725710AbfEXEdv (ORCPT ); Fri, 24 May 2019 00:33:51 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x4O4XiT8031190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 May 2019 00:33:45 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 5D535420481; Fri, 24 May 2019 00:33:44 -0400 (EDT) Date: Fri, 24 May 2019 00:33:44 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] e2fsck: handle verity files in scan_extent_node() Message-ID: <20190524043344.GF2532@mit.edu> References: <20190523153033.22487-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523153033.22487-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, May 23, 2019 at 08:30:33AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Don't report PR_1_EXTENT_END_OUT_OF_BOUNDS on verity files during > scan_extent_node(), since they will have blocks stored past i_size. > > This was missed during the earlier fix because this check only triggers > if the inode has enough extents to need at least one extent index node. > > This bug is causing one of the fs-verity xfstests to fail with the > reworked fs-verity patchset. > > Fixes: 3baafde6a8ae ("e2fsck: allow verity files to have initialized blocks past i_size") > Signed-off-by: Eric Biggers Thanks, applied. Could you supply a small (~200k) file system with a verity-protected file so we can add a regression test? Many thanks!! - Ted