From: Jan Kara <jack@suse.cz>
To: Chengguang Xu <cgxu519@zoho.com.cn>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: code cleanup for ext2_preread_inode()
Date: Tue, 28 May 2019 09:52:13 +0200 [thread overview]
Message-ID: <20190528075213.GA9607@quack2.suse.cz> (raw)
In-Reply-To: <20190528053231.12364-1-cgxu519@zoho.com.cn>
On Tue 28-05-19 13:32:31, Chengguang Xu wrote:
> Calling bdi_rw_congested() instead of calling
> bdi_read_congested() and bdi_write_congested().
>
> Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>
Thanks! Applied.
Honza
> ---
> fs/ext2/ialloc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index a0c5ea91fcd4..334dea4e499d 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -172,9 +172,7 @@ static void ext2_preread_inode(struct inode *inode)
> struct backing_dev_info *bdi;
>
> bdi = inode_to_bdi(inode);
> - if (bdi_read_congested(bdi))
> - return;
> - if (bdi_write_congested(bdi))
> + if (bdi_rw_congested(bdi))
> return;
>
> block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
> --
> 2.20.1
>
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-05-28 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 5:32 [PATCH] ext2: code cleanup for ext2_preread_inode() Chengguang Xu
2019-05-28 7:52 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528075213.GA9607@quack2.suse.cz \
--to=jack@suse.cz \
--cc=cgxu519@zoho.com.cn \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).