From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Lukas Czerner <lczerner@redhat.com>,
linux-ext4@vger.kernel.org, Jan Kara <jack@suse.com>
Subject: Re: How to package e2scrub
Date: Thu, 30 May 2019 11:59:07 +0200 [thread overview]
Message-ID: <20190530095907.GA29237@quack2.suse.cz> (raw)
In-Reply-To: <20190529235948.GB3671@mit.edu>
On Wed 29-05-19 19:59:48, Theodore Ts'o wrote:
> On Wed, May 29, 2019 at 02:06:03PM +0200, Lukas Czerner wrote:
> > What I am going to do is to split the systemd service into a separate
> > package and I'd like to come to some agreement about the name of the
> > package so that we can have the same name across distributions (at least
> > Fedora/Debian/Suse).
>
> Hmm.... what keeping the service as part of the e2fsprogs package, but
> then not enabling out of the box. That is, require that user run:
>
> systemctl enable e2scrub_all.timer
>
> in order to actually get the feature? (They can also disable it using
> "systemctl disable e2scrub_all.timer".)
>
> As far as the cron job is concerned, we could just leave the crontab
> entry commented out by default, and require that the user go in and
> edit the /etc/cron.d/e2scrub_all file if they want to enable it. Not
> packaging it also seems fine; Debian's support for non-systemd
> configurations is at best marginal at this point, and while I'm not a
> fan of systemd, I'm also a realist...
>
> What do folks think?
Yeah, my plan is to just not package cron bits at all since openSUSE / SLES
support only systemd init anyway these days (and in fact our distro people
want to deprecate cron in favor of systemd). I guess I'll split off the
scrub bits into a separate sub-package (likely e2fsprogs will suggest
installation of this sub-package) and the service will be disabled by
default.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-05-30 9:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:06 How to package e2scrub Lukas Czerner
2019-05-29 18:21 ` Darrick J. Wong
2019-05-29 18:34 ` Eric Sandeen
2019-05-30 6:04 ` Christoph Hellwig
2019-05-30 15:28 ` Darrick J. Wong
2019-06-03 11:19 ` Emmanuel Florac
2019-06-03 12:39 ` Lukas Czerner
2019-05-29 23:59 ` Theodore Ts'o
2019-05-30 1:54 ` Andreas Dilger
2019-05-30 9:59 ` Jan Kara [this message]
2019-05-30 13:51 ` Theodore Ts'o
2019-05-31 10:07 ` Jan Kara
2019-05-31 14:10 ` Theodore Ts'o
2019-05-31 21:43 ` Andreas Dilger
2019-06-03 9:30 ` Jan Kara
2019-05-31 15:43 ` Darrick J. Wong
2019-06-03 12:32 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530095907.GA29237@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).