From: Jan Kara <jack@suse.cz>
To: Chengguang Xu <cgxu519@zoho.com.cn>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: add missing brelse() in ext2_new_inode()
Date: Thu, 30 May 2019 13:35:47 +0200 [thread overview]
Message-ID: <20190530113547.GD29237@quack2.suse.cz> (raw)
In-Reply-To: <20190530101042.32197-1-cgxu519@zoho.com.cn>
On Thu 30-05-19 18:10:42, Chengguang Xu wrote:
> There is a missing brelse of bitmap_bh in an error
> path of ext2_new_inode().
>
> Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>
Thanks for the fix! Applied.
Honza
> ---
> fs/ext2/ialloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index 334dea4e499d..fda7d3f5b4be 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -509,6 +509,7 @@ struct inode *ext2_new_inode(struct inode *dir, umode_t mode,
> /*
> * Scanned all blockgroups.
> */
> + brelse(bitmap_bh);
> err = -ENOSPC;
> goto fail;
> got:
> --
> 2.20.1
>
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-05-30 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 10:10 [PATCH] ext2: add missing brelse() in ext2_new_inode() Chengguang Xu
2019-05-30 11:35 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530113547.GD29237@quack2.suse.cz \
--to=jack@suse.cz \
--cc=cgxu519@zoho.com.cn \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).