From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13581C04AB5 for ; Thu, 6 Jun 2019 16:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB73920868 for ; Thu, 6 Jun 2019 16:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729502AbfFFQJf (ORCPT ); Thu, 6 Jun 2019 12:09:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:33754 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729191AbfFFQJe (ORCPT ); Thu, 6 Jun 2019 12:09:34 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 09:09:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,559,1557212400"; d="scan'208";a="182358981" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by fmsmga002.fm.intel.com with ESMTP; 06 Jun 2019 09:09:34 -0700 Date: Thu, 6 Jun 2019 09:10:46 -0700 From: Ira Weiny To: Christoph Hellwig Cc: Dan Williams , Jan Kara , Theodore Ts'o , Jeff Layton , Dave Chinner , Matthew Wilcox , linux-xfs@vger.kernel.org, Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RFC 03/10] mm/gup: Pass flags down to __gup_device_huge* calls Message-ID: <20190606161045.GA11331@iweiny-DESK2.sc.intel.com> References: <20190606014544.8339-1-ira.weiny@intel.com> <20190606014544.8339-4-ira.weiny@intel.com> <20190606061819.GA20520@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606061819.GA20520@infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 05, 2019 at 11:18:19PM -0700, Christoph Hellwig wrote: > On Wed, Jun 05, 2019 at 06:45:36PM -0700, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > In order to support checking for a layout lease on a FS DAX inode these > > calls need to know if FOLL_LONGTERM was specified. > > > > Prepare for this with this patch. > > The GUP fast argument passing is a mess. That is why I've come up > with this as part of the (not ready) get_user_pages_fast_bvec > implementation: > > http://git.infradead.org/users/hch/misc.git/commitdiff/c3d019802dbde5a4cc4160e7ec8ccba479b19f97 Agreed that looks better. And I'm sure I will have to re-roll this to deal with conflicts with this set. But for now I needed this for the follow ons and having a nice separate little patch like this means I can just drop it after I get your clean up! :-D Ira