From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92C2C31E46 for ; Wed, 12 Jun 2019 12:32:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D93120874 for ; Wed, 12 Jun 2019 12:32:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438997AbfFLMcG (ORCPT ); Wed, 12 Jun 2019 08:32:06 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:48390 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2438952AbfFLMcF (ORCPT ); Wed, 12 Jun 2019 08:32:05 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x5CCW0Ri020181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jun 2019 08:32:01 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 6EEBC420484; Wed, 12 Jun 2019 08:32:00 -0400 (EDT) Date: Wed, 12 Jun 2019 08:32:00 -0400 From: "Theodore Ts'o" To: Gabriel Krisman Bertazi Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org, "Lakshmipathi.G" Subject: Re: [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature Message-ID: <20190612123200.GA2736@mit.edu> References: <20190610173541.20511-1-krisman@collabora.com> <20190610173541.20511-2-krisman@collabora.com> <20190611121546.GC2774@mit.edu> <85y327z9ad.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85y327z9ad.fsf@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 12, 2019 at 01:01:46AM -0400, Gabriel Krisman Bertazi wrote: > > I tried out this test, and it's apparently failing for me using > > e2fsprogs 1.45.2; it looks like it's a whitespace issue? > > Hi Ted, > > Yes, definitely just whitespace. But i don't understand why you are > getting this behavior. I tried both with the master branch of e2fsprogs > and the tagged commit of v1.45.2 and on both occasions the test succeed > in my system. For sure I can use filter_spaces but I'm puzzled why I > can't reproduce this. That's wierd. The kvm-xfstests appliance VM that's uploaded to https://mirrors.edge.kernel.org/pub/linux/kernel/people/tytso/kvm-xfstests/ shows the problem. With your patch applied to the xfstests-dev directory after checking out xfstests-bld (see [1] for more information if you haven't used kvm-xfstests before), it's reproducible via: kvm-xfstests -I ../out_dir/root_fs.img.amd64 --update-xfstests-tar -c 4k shared/012 [1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md - Ted