From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA88EC31E52 for ; Sat, 15 Jun 2019 14:42:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 943F92183F for ; Sat, 15 Jun 2019 14:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbfFOOmi (ORCPT ); Sat, 15 Jun 2019 10:42:38 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:53580 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726405AbfFOOmi (ORCPT ); Sat, 15 Jun 2019 10:42:38 -0400 Received: from callcc.thunk.org (rrcs-74-87-88-165.west.biz.rr.com [74.87.88.165]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x5FEg8RS031455 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 15 Jun 2019 10:42:09 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id AFE89420484; Sat, 15 Jun 2019 10:42:07 -0400 (EDT) Date: Sat, 15 Jun 2019 10:42:07 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, Jaegeuk Kim , Victor Hsieh , Dave Chinner , Christoph Hellwig , "Darrick J . Wong" , Linus Torvalds Subject: Re: [PATCH v4 07/16] fs-verity: add the hook for file ->open() Message-ID: <20190615144207.GH6142@mit.edu> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-8-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606155205.2872-8-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 06, 2019 at 08:51:56AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Add the fsverity_file_open() function, which prepares an fs-verity file > to be read from. If not already done, it loads the fs-verity descriptor > from the filesystem and sets up an fsverity_info structure for the inode > which describes the Merkle tree and contains the file measurement. It > also denies all attempts to open verity files for writing. > > This commit also begins the include/linux/fsverity.h header, which > declares the interface between fs/verity/ and filesystems. > > Signed-off-by: Eric Biggers Looks good; you can add: Reviewed-off-by: Theodore Ts'o - Ted > +/* > + * Validate the given fsverity_descriptor and create a new fsverity_info from > + * it. The signature (if present) is also checked. > + */ > +struct fsverity_info *fsverity_create_info(const struct inode *inode, > + const void *_desc, size_t desc_size) Well, technically it's not checked (yet). It doesn't get checked until [PATCH 13/16]: support builtin file signatures. If we want to be really nit-picky, that portion of the comment could be moved to later in the series.