From: "Theodore Ts'o" <tytso@mit.edu>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
"Lakshmipathi.G" <lakshmipathi.ganapathi@collabora.co.uk>
Subject: Re: [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature
Date: Sun, 16 Jun 2019 16:01:54 -0400 [thread overview]
Message-ID: <20190616200154.GA7251@mit.edu> (raw)
In-Reply-To: <20190616144440.GD15846@desktop>
On Sun, Jun 16, 2019 at 10:44:40PM +0800, Eryu Guan wrote:
> On Wed, Jun 12, 2019 at 02:40:33PM -0400, Gabriel Krisman Bertazi wrote:
> Test looks good to me, and test passes for me with v5.2-rc4 kernel and
> latest e2fsprogs, thanks! Just that, I moved the test to generic, as we
> have all the needed _require rules ready to _notrun on unsupported fs,
> so it's ready to be generic. (Sorry I was not involved with the
> ext4-shared-generic discussion in the first place)
Just to clear up my confusion, what's the distinction between shared
and generic? Is it that if there are explicit "only run this test on
file systems xxx, yyy, and zzz declarations", then it should be
shared, and otherwise it should be in generic?
- Ted
next prev parent reply other threads:[~2019-06-16 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 18:40 [PATCH v3 1/2] common/casefold: Add infrastructure to test filename casefold feature Gabriel Krisman Bertazi
2019-06-12 18:40 ` [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature Gabriel Krisman Bertazi
2019-06-16 14:44 ` Eryu Guan
2019-06-16 20:01 ` Theodore Ts'o [this message]
2019-06-20 11:29 ` Eryu Guan
2019-06-20 16:21 ` Removing the shared class of tests Theodore Ts'o
2019-06-20 17:50 ` Darrick J. Wong
2019-06-20 21:46 ` Theodore Ts'o
2019-06-24 7:16 ` Christoph Hellwig
2019-06-24 13:07 ` Theodore Ts'o
2019-06-24 17:05 ` Darrick J. Wong
2019-06-24 17:25 ` Theodore Ts'o
2019-06-26 2:37 ` Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2019-06-10 17:35 [PATCH v3 1/2] common/casefold: Add infrastructure to test filename casefold feature Gabriel Krisman Bertazi
2019-06-10 17:35 ` [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature Gabriel Krisman Bertazi
2019-06-11 12:15 ` Theodore Ts'o
2019-06-12 5:01 ` Gabriel Krisman Bertazi
2019-06-12 12:32 ` Theodore Ts'o
2019-06-12 18:32 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190616200154.GA7251@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=krisman@collabora.com \
--cc=lakshmipathi.ganapathi@collabora.co.uk \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).