From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2CA4C31E57 for ; Mon, 17 Jun 2019 14:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A59EA206B7 for ; Mon, 17 Jun 2019 14:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfFQOKI (ORCPT ); Mon, 17 Jun 2019 10:10:08 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:59006 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725906AbfFQOKI (ORCPT ); Mon, 17 Jun 2019 10:10:08 -0400 Received: from callcc.thunk.org (rrcs-74-87-88-165.west.biz.rr.com [74.87.88.165]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x5HE9qft017594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2019 10:09:54 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 69A45420484; Mon, 17 Jun 2019 10:09:52 -0400 (EDT) Date: Mon, 17 Jun 2019 10:09:52 -0400 From: "Theodore Ts'o" To: Zhangjs Jinshui Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, zachary@baishancloud.com Subject: Re: [PATCH] ext4: make __ext4_get_inode_loc plug Message-ID: <20190617140952.GF4358@mit.edu> Mail-Followup-To: Theodore Ts'o , Zhangjs Jinshui , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, zachary@baishancloud.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 17, 2019 at 03:11:21PM +0800, Zhangjs Jinshui wrote: > If the task is unplugged when called, the inode_readahead_blks may not be > merged, > these will cause small pieces of io, It should be plugged. > > Signed-off-by: zhangjs This patch is white space damaged. Please see: https://www.kernel.org/doc/html/latest/process/email-clients.html for more information. Could you resend using an appropriate mail client? Many thanks! - Ted