From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21877C43613 for ; Thu, 20 Jun 2019 04:12:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04C2B2085A for ; Thu, 20 Jun 2019 04:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726594AbfFTEMK (ORCPT ); Thu, 20 Jun 2019 00:12:10 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47094 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725781AbfFTEMK (ORCPT ); Thu, 20 Jun 2019 00:12:10 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x5K4C5O4008236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2019 00:12:05 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 17899420484; Thu, 20 Jun 2019 00:12:05 -0400 (EDT) Date: Thu, 20 Jun 2019 00:12:05 -0400 From: "Theodore Ts'o" To: Colin King Cc: Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove redundant assignment to node Message-ID: <20190620041204.GC15783@mit.edu> Mail-Followup-To: Theodore Ts'o , Colin King , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190619090007.26962-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190619090007.26962-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 19, 2019 at 10:00:06AM +0100, Colin King wrote: > From: Colin Ian King > > Pointer 'node' is assigned a value that is never read, node is > later overwritten when it re-assigned a different value inside > the while-loop. The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thanks. - Ted