* [PATCH] ext4: remove redundant assignment to node
@ 2019-06-19 9:00 Colin King
2019-06-19 11:13 ` Jan Kara
2019-06-20 4:12 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-06-19 9:00 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, linux-ext4
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer 'node' is assigned a value that is never read, node is
later overwritten when it re-assigned a different value inside
the while-loop. The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ext4/extents_status.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
index 023a3eb3afa3..7521de2dcf3a 100644
--- a/fs/ext4/extents_status.c
+++ b/fs/ext4/extents_status.c
@@ -1317,7 +1317,6 @@ static int es_do_reclaim_extents(struct ext4_inode_info *ei, ext4_lblk_t end,
es = __es_tree_search(&tree->root, ei->i_es_shrink_lblk);
if (!es)
goto out_wrap;
- node = &es->rb_node;
while (*nr_to_scan > 0) {
if (es->es_lblk > end) {
ei->i_es_shrink_lblk = end + 1;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove redundant assignment to node
2019-06-19 9:00 [PATCH] ext4: remove redundant assignment to node Colin King
@ 2019-06-19 11:13 ` Jan Kara
2019-06-20 4:12 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2019-06-19 11:13 UTC (permalink / raw)
To: Colin King
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, kernel-janitors,
linux-kernel
On Wed 19-06-19 10:00:06, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer 'node' is assigned a value that is never read, node is
> later overwritten when it re-assigned a different value inside
> the while-loop. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/extents_status.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 023a3eb3afa3..7521de2dcf3a 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -1317,7 +1317,6 @@ static int es_do_reclaim_extents(struct ext4_inode_info *ei, ext4_lblk_t end,
> es = __es_tree_search(&tree->root, ei->i_es_shrink_lblk);
> if (!es)
> goto out_wrap;
> - node = &es->rb_node;
> while (*nr_to_scan > 0) {
> if (es->es_lblk > end) {
> ei->i_es_shrink_lblk = end + 1;
> --
> 2.20.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove redundant assignment to node
2019-06-19 9:00 [PATCH] ext4: remove redundant assignment to node Colin King
2019-06-19 11:13 ` Jan Kara
@ 2019-06-20 4:12 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2019-06-20 4:12 UTC (permalink / raw)
To: Colin King; +Cc: Andreas Dilger, linux-ext4, kernel-janitors, linux-kernel
On Wed, Jun 19, 2019 at 10:00:06AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer 'node' is assigned a value that is never read, node is
> later overwritten when it re-assigned a different value inside
> the while-loop. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-20 4:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 9:00 [PATCH] ext4: remove redundant assignment to node Colin King
2019-06-19 11:13 ` Jan Kara
2019-06-20 4:12 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).