* [PATCH] jbd2: drop declaration of journal_sync_buffer()
@ 2019-06-20 21:32 Theodore Ts'o
2019-06-20 21:34 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2019-06-20 21:32 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o
The journal_sync_buffer() function was never carried over from jbd to
jbd2. So get rid of the vestigal declaration of this (non-existent)
function.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
fs/jbd2/journal.c | 3 ---
include/linux/jbd2.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 17f679aeba7c..953990eb70a9 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
EXPORT_SYMBOL(jbd2_journal_set_triggers);
EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
EXPORT_SYMBOL(jbd2_journal_forget);
-#if 0
-EXPORT_SYMBOL(journal_sync_buffer);
-#endif
EXPORT_SYMBOL(jbd2_journal_flush);
EXPORT_SYMBOL(jbd2_journal_revoke);
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 0e0393e7f41a..df03825ad1a1 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -1373,7 +1373,6 @@ void jbd2_journal_set_triggers(struct buffer_head *,
struct jbd2_buffer_trigger_type *type);
extern int jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
extern int jbd2_journal_forget (handle_t *, struct buffer_head *);
-extern void journal_sync_buffer (struct buffer_head *);
extern int jbd2_journal_invalidatepage(journal_t *,
struct page *, unsigned int, unsigned int);
extern int jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jbd2: drop declaration of journal_sync_buffer()
2019-06-20 21:32 [PATCH] jbd2: drop declaration of journal_sync_buffer() Theodore Ts'o
@ 2019-06-20 21:34 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-06-20 21:34 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List
On Thu, Jun 20, 2019 at 05:32:28PM -0400, Theodore Ts'o wrote:
> The journal_sync_buffer() function was never carried over from jbd to
> jbd2. So get rid of the vestigal declaration of this (non-existent)
> function.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/jbd2/journal.c | 3 ---
> include/linux/jbd2.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 17f679aeba7c..953990eb70a9 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
> EXPORT_SYMBOL(jbd2_journal_set_triggers);
> EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
> EXPORT_SYMBOL(jbd2_journal_forget);
> -#if 0
> -EXPORT_SYMBOL(journal_sync_buffer);
> -#endif
> EXPORT_SYMBOL(jbd2_journal_flush);
> EXPORT_SYMBOL(jbd2_journal_revoke);
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 0e0393e7f41a..df03825ad1a1 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1373,7 +1373,6 @@ void jbd2_journal_set_triggers(struct buffer_head *,
> struct jbd2_buffer_trigger_type *type);
> extern int jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
> extern int jbd2_journal_forget (handle_t *, struct buffer_head *);
> -extern void journal_sync_buffer (struct buffer_head *);
> extern int jbd2_journal_invalidatepage(journal_t *,
> struct page *, unsigned int, unsigned int);
> extern int jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-20 21:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-20 21:32 [PATCH] jbd2: drop declaration of journal_sync_buffer() Theodore Ts'o
2019-06-20 21:34 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).