From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] jbd2: drop declaration of journal_sync_buffer()
Date: Thu, 20 Jun 2019 14:34:54 -0700 [thread overview]
Message-ID: <20190620213454.GA5375@magnolia> (raw)
In-Reply-To: <20190620213228.8191-1-tytso@mit.edu>
On Thu, Jun 20, 2019 at 05:32:28PM -0400, Theodore Ts'o wrote:
> The journal_sync_buffer() function was never carried over from jbd to
> jbd2. So get rid of the vestigal declaration of this (non-existent)
> function.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/jbd2/journal.c | 3 ---
> include/linux/jbd2.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 17f679aeba7c..953990eb70a9 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
> EXPORT_SYMBOL(jbd2_journal_set_triggers);
> EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
> EXPORT_SYMBOL(jbd2_journal_forget);
> -#if 0
> -EXPORT_SYMBOL(journal_sync_buffer);
> -#endif
> EXPORT_SYMBOL(jbd2_journal_flush);
> EXPORT_SYMBOL(jbd2_journal_revoke);
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 0e0393e7f41a..df03825ad1a1 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1373,7 +1373,6 @@ void jbd2_journal_set_triggers(struct buffer_head *,
> struct jbd2_buffer_trigger_type *type);
> extern int jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
> extern int jbd2_journal_forget (handle_t *, struct buffer_head *);
> -extern void journal_sync_buffer (struct buffer_head *);
> extern int jbd2_journal_invalidatepage(journal_t *,
> struct page *, unsigned int, unsigned int);
> extern int jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
> --
> 2.22.0
>
prev parent reply other threads:[~2019-06-20 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 21:32 [PATCH] jbd2: drop declaration of journal_sync_buffer() Theodore Ts'o
2019-06-20 21:34 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620213454.GA5375@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).