From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Eryu Guan <guaneryu@gmail.com>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
"Lakshmipathi.G" <lakshmipathi.ganapathi@collabora.co.uk>
Subject: Re: Removing the shared class of tests
Date: Mon, 24 Jun 2019 00:16:10 -0700 [thread overview]
Message-ID: <20190624071610.GA10195@infradead.org> (raw)
In-Reply-To: <20190620175035.GA5380@magnolia>
On Thu, Jun 20, 2019 at 10:50:35AM -0700, Darrick J. Wong wrote:
> > I'm not sure why shared/011 is only run on ext4 and btrfs. Does
> > cgroup-aware writeback not work on other file systems?
>
> IIRC it doesn't work on xfs because the author never quite answered
> Dave's question about whether or not it would cause ... io priority
> inversions or something? There was some unanswered question (iirc) so
> nobody RVB'd the patch and it never went upstream.
I've got a new and tested patch to support cgroup writeback on xfs that
I'll send out today. But even with that lots of file systems don't
support cgroup writeback and there is no easy way to autodetect the
support. As far as I an tell ext2 and f2fs also support cgroup
writeback, so they should be added a well.
As for the higher level question? The shared tests always confused the
heck out of me. generic with the right feature checks seem like a much
better idea.
next prev parent reply other threads:[~2019-06-24 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 18:40 [PATCH v3 1/2] common/casefold: Add infrastructure to test filename casefold feature Gabriel Krisman Bertazi
2019-06-12 18:40 ` [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature Gabriel Krisman Bertazi
2019-06-16 14:44 ` Eryu Guan
2019-06-16 20:01 ` Theodore Ts'o
2019-06-20 11:29 ` Eryu Guan
2019-06-20 16:21 ` Removing the shared class of tests Theodore Ts'o
2019-06-20 17:50 ` Darrick J. Wong
2019-06-20 21:46 ` Theodore Ts'o
2019-06-24 7:16 ` Christoph Hellwig [this message]
2019-06-24 13:07 ` Theodore Ts'o
2019-06-24 17:05 ` Darrick J. Wong
2019-06-24 17:25 ` Theodore Ts'o
2019-06-26 2:37 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624071610.GA10195@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=krisman@collabora.com \
--cc=lakshmipathi.ganapathi@collabora.co.uk \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).