From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BIGNUM_EMAILS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CAAC5B57D for ; Wed, 3 Jul 2019 00:27:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06D0E21E6E for ; Wed, 3 Jul 2019 00:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727082AbfGCA1f (ORCPT ); Tue, 2 Jul 2019 20:27:35 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:32964 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726291AbfGCA1f (ORCPT ); Tue, 2 Jul 2019 20:27:35 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-109.corp.google.com [104.133.0.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x62LvS8G031701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Jul 2019 17:57:29 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 8CE0E42002E; Tue, 2 Jul 2019 17:57:28 -0400 (EDT) Date: Tue, 2 Jul 2019 17:57:28 -0400 From: "Theodore Ts'o" To: Gabriel Krisman Bertazi Cc: Dan Carpenter , linux-ext4@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] ext4: Fix coverity warning on error path of filename setup Message-ID: <20190702215728.GI3032@mit.edu> References: <20190624122906.GA30836@mwanda> <85r27dlay3.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85r27dlay3.fsf@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jun 28, 2019 at 04:19:32PM -0400, Gabriel Krisman Bertazi wrote: > Dan Carpenter writes: > > > Hello Gabriel Krisman Bertazi, > > > > The patch 3ae72562ad91: "ext4: optimize case-insensitive lookups" > > from Jun 19, 2019, leads to the following static checker warning: > > Hi, > > The patch below should fix this issue. > > -- >8 -- > Subject: [PATCH] ext4: Fix coverity warning on error path of filename setup > > Fix the following coverity warning reported by Dan Carpenter: > > fs/ext4/namei.c:1311 ext4_fname_setup_ci_filename() > warn: 'cf_name->len' unsigned <= 0 > > Fixes: 3ae72562ad91 ("ext4: optimize case-insensitive lookups") > Signed-off-by: Gabriel Krisman Bertazi > Reported-by: Dan Carpenter Applied, thanks. - Ted