linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: yangerkun <yangerkun@huawei.com>
Cc: jack@suse.com, linux-ext4@vger.kernel.org, houtao1@huawei.com,
	yi.zhang@huawei.com, miaoxie@huawei.com
Subject: Re: [PATCH v2] ext4: fix warning when turn on dioread_nolock and inline_data
Date: Thu, 18 Jul 2019 11:05:46 -0400	[thread overview]
Message-ID: <20190718150546.GA20078@mit.edu> (raw)
In-Reply-To: <1562313694-60126-1-git-send-email-yangerkun@huawei.com>

On Fri, Jul 05, 2019 at 04:01:34PM +0800, yangerkun wrote:
> mkfs.ext4 -O inline_data /dev/vdb
> mount -o dioread_nolock /dev/vdb /mnt
> echo "some inline data..." >> /mnt/test-file
> echo "some inline data..." >> /mnt/test-file
> sync
> 
> The above script will trigger "WARN_ON(!io_end->handle && sbi->s_journal)"
> because ext4_should_dioread_nolock() returns false for a file with inline
> data. Move the check to a place after we have already removed the inline
> data and prepared inode to write normal pages.
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: yangerkun <yangerkun@huawei.com>

Thanks, applied.

					- Ted

      reply	other threads:[~2019-07-18 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05  8:01 [PATCH v2] ext4: fix warning when turn on dioread_nolock and inline_data yangerkun
2019-07-18 15:05 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718150546.GA20078@mit.edu \
    --to=tytso@mit.edu \
    --cc=houtao1@huawei.com \
    --cc=jack@suse.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).