From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF6CC7618F for ; Mon, 22 Jul 2019 21:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4801F21901 for ; Mon, 22 Jul 2019 21:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730636AbfGVVCl (ORCPT ); Mon, 22 Jul 2019 17:02:41 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40602 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729059AbfGVVCl (ORCPT ); Mon, 22 Jul 2019 17:02:41 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-99.corp.google.com [104.133.0.99] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x6ML2atk007161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Jul 2019 17:02:37 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 054764202F5; Mon, 22 Jul 2019 17:02:35 -0400 (EDT) Date: Mon, 22 Jul 2019 17:02:35 -0400 From: "Theodore Y. Ts'o" To: Andreas Dilger Cc: Harshad Shirwadkar , Ext4 Developers List Subject: Re: [PATCH 01/11] ext4: add handling for extended mount options Message-ID: <20190722210235.GE16313@mit.edu> References: <20190722040011.18892-1-harshadshirwadkar@gmail.com> <41522E01-D5E5-4DC6-8AD4-09E3FA19F112@dilger.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41522E01-D5E5-4DC6-8AD4-09E3FA19F112@dilger.ca> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jul 22, 2019 at 12:15:11PM -0600, Andreas Dilger wrote: > Unless I missed it, this patch series needs a 00/11 email that describes > *what* "fast commit" is, and why we want it. This should include some > benchmark results, since (I'd assume) that the "fast" part of the feature > name implies a performance improvement? For background, it's a simplified version of the scheme proposed by Park and Shin, in their paper, "iJournaling: Fine-Grained Journaling for Improving the Latency of Fsync System Call"[1] [1] https://www.usenix.org/conference/atc17/technical-sessions/presentation/park I agree we should have a cover letter for this patch series. Also, we should add documentation to Documentation/filesystems/journaling.rst about this feature; what it does, how it works, its basic on-disk format changes, etc. The fs/jbd2 layer isn't as well documented as the fs/ext4 code, and bringing Documentation/filesystems/journaling.rst to the same level as Documentation/filesystems/ext4/* isn't a fair/reasonable request. On the other hand, documenting what is being added by this patch series is something that I think we should do. - Ted