From: Eric Biggers <ebiggers@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] ext4: add a new ioctl EXT4_IOC_GETSTATE
Date: Fri, 9 Aug 2019 12:18:12 -0700 [thread overview]
Message-ID: <20190809191810.GA100971@gmail.com> (raw)
In-Reply-To: <20190809181831.10618-3-tytso@mit.edu>
On Fri, Aug 09, 2019 at 02:18:31PM -0400, Theodore Ts'o wrote:
> The new ioctl EXT4_IOC_GETSTATE returns some of the dynamic state of
> an ext4 inode for debugging purposes.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> fs/ext4/ext4.h | 11 +++++++++++
> fs/ext4/ioctl.c | 17 +++++++++++++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index f6c305b43ffa..58b7a0905186 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -651,6 +651,7 @@ enum {
> #define EXT4_IOC_GET_ENCRYPTION_POLICY FS_IOC_GET_ENCRYPTION_POLICY
> /* ioctl codes 19--2F are reserved for fscrypt */
> #define EXT4_IOC_CLEAR_ES_CACHE _IO('f', 30)
> +#define EXT4_IOC_GETSTATE _IOW('f', 30, __u32)
30 == 0x1e overlaps with the range claimed to be reserved for fscrypt.
Also, these two new ioctls are both number 30, which means they can't be
controlled separately by SELinux, which only looks at the number.
- Eric
next prev parent reply other threads:[~2019-08-09 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 18:18 [PATCH 1/3] ext4: return the extent cache information via fiemap Theodore Ts'o
2019-08-09 18:18 ` [PATCH 2/3] ext4: add a new ioctl EXT4_IOC_CLEAR_ES_CACHE Theodore Ts'o
2019-08-09 18:18 ` [PATCH 3/3] ext4: add a new ioctl EXT4_IOC_GETSTATE Theodore Ts'o
2019-08-09 19:18 ` Eric Biggers [this message]
2019-08-10 0:12 ` Theodore Y. Ts'o
2019-08-11 21:38 ` Eric Biggers
2019-08-10 7:33 ` [PATCH 1/3] ext4: return the extent cache information via fiemap Christoph Hellwig
2019-08-11 16:15 ` Theodore Y. Ts'o
2019-08-12 6:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809191810.GA100971@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).