From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF008C31E40 for ; Mon, 12 Aug 2019 17:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BCB120644 for ; Mon, 12 Aug 2019 17:18:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="WKjvzGbY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfHLRSd (ORCPT ); Mon, 12 Aug 2019 13:18:33 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37254 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbfHLRSd (ORCPT ); Mon, 12 Aug 2019 13:18:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+YNZsLLrlPEHgxpe/aXTTjPaVKmiuk5SL+l/sNwb+ns=; b=WKjvzGbYVhYzvQjOTh2WsDgiT 6hxUSVu9+fTGD94fmSJtIGQEk9R79K5WuN9GVnWNHw525ZtBf6q7le7b1cXTsbWxoRhcl0jKKh6RS rOXYfhF+XI9EmNidIXBwxX6lt1V8ZA7V0qFHLBpo24OOpzf3eLDA5/g/Kmk11DSy3uN+zyKwJikjN poMe2UL1OklLd7Dar2GoMkgdCV/tNHOk0wVp+xYLaYkjyal0tGQKCmOILf4Iyz7wJgXFJ2iYNN5Ns td4KwsHm/lxUztsD1iOQNHUp50ZDbJJoJ2mnS8A7mvYB/JfaTPRz8C1mKXSjJ4l/nKPPl9FOIRUpO jlnOoXV5A==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hxDxo-0001Lt-I3; Mon, 12 Aug 2019 17:18:32 +0000 Date: Mon, 12 Aug 2019 10:18:32 -0700 From: Christoph Hellwig To: Matthew Bobrowski Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, tytso@mit.edu, riteshh@linux.ibm.com Subject: Re: [PATCH 3/5] iomap: modify ->end_io() calling convention Message-ID: <20190812171832.GA24564@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org please add linux-xfs to the cc list for the whole series. Besides touching xfs itself it is also mentioned in MAINTAINERS for the iomap code. On Mon, Aug 12, 2019 at 10:53:11PM +1000, Matthew Bobrowski wrote: > - if (size <= 0) > - return size; > + if (error || !size) > + return error ? error : size; This should be: if (error) return error; if (!size) return 0; > if (flags & IOMAP_DIO_COW) { > - error = xfs_reflink_end_cow(ip, offset, size); > - if (error) > + ret = xfs_reflink_end_cow(ip, offset, size); > + if (ret) I think we can just keep reusing error here. > +typedef int (iomap_dio_end_io_t)(struct kiocb *iocb, ssize_t size, > + ssize_t error, unsigned int flags); error should be an int and not a ssize_t.