From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: harshad shirwadkar <harshadshirwadkar@gmail.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2 05/12] jbd2: fast-commit commit path new APIs
Date: Mon, 12 Aug 2019 14:01:06 -0400 [thread overview]
Message-ID: <20190812180106.GB28705@mit.edu> (raw)
In-Reply-To: <CAD+ocbxwraTHT0wPCZgtjC8mJ7OU6wpkd7PgC7_YW=G9W-arDQ@mail.gmail.com>
On Mon, Aug 12, 2019 at 10:41:48AM -0700, harshad shirwadkar wrote:
> I see, so you mean each fsync() call will result in exactly one inode
> to be committed (the inode on which fsync was called), right? I agree
> this doesn't need to go through JBD2 but we need a mechanism to inform
> JBD2 about this fast commit since JBD2 maintains sub-transaction ID.
> JBD2 will in turn need to make sure that a subtid was allocated for
> such a fast commit and it was incremented once the fast commit was
> successful as well.
Why does JBD2 need to maintain the sub-transaction ID? We can only
have a single fast commit happening at a time, and while a fast commit
is happening we can't allow a full commit from happening (or vice
versa). So we need a mutex which enforces this, the transaction id
can just be a field in the transaction structure.
Cheers,
- Ted
next prev parent reply other threads:[~2019-08-12 18:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 3:45 [PATCH v2 00/12] ext4: add support fast commit Harshad Shirwadkar
2019-08-09 3:45 ` [PATCH v2 01/12] ext4: add handling for extended mount options Harshad Shirwadkar
2019-08-09 19:41 ` Andreas Dilger
2019-08-12 14:22 ` Theodore Y. Ts'o
2019-08-09 3:45 ` [PATCH v2 02/12] jbd2: add fast commit fields to journal_s structure Harshad Shirwadkar
2019-08-09 19:48 ` Andreas Dilger
2019-10-01 7:50 ` harshad shirwadkar
2019-08-09 3:45 ` [PATCH v2 03/12] jbd2: fast commit setup and enable Harshad Shirwadkar
2019-08-09 20:02 ` Andreas Dilger
2019-10-01 7:52 ` harshad shirwadkar
2019-11-01 11:22 ` xiaohui li
2019-08-09 3:45 ` [PATCH v2 04/12] jbd2: fast-commit commit path changes Harshad Shirwadkar
2019-08-09 20:22 ` Andreas Dilger
2019-10-01 7:43 ` harshad shirwadkar
2019-08-09 3:45 ` [PATCH v2 05/12] jbd2: fast-commit commit path new APIs Harshad Shirwadkar
2019-08-09 20:38 ` Andreas Dilger
2019-08-09 21:11 ` Andreas Dilger
2019-08-09 21:20 ` harshad shirwadkar
2019-08-12 16:04 ` Theodore Y. Ts'o
2019-08-12 17:41 ` harshad shirwadkar
2019-08-12 18:01 ` Theodore Y. Ts'o [this message]
2019-08-09 3:45 ` [PATCH v2 06/12] jbd2: fast-commit recovery path changes Harshad Shirwadkar
2019-08-09 20:57 ` Andreas Dilger
2019-08-09 3:45 ` [PATCH v2 07/12] ext4: add fields that are needed to track changed files Harshad Shirwadkar
2019-08-09 21:23 ` Andreas Dilger
2019-10-01 7:50 ` harshad shirwadkar
2019-08-09 3:45 ` [PATCH v2 08/12] ext4: track changed files for fast commit Harshad Shirwadkar
2019-08-09 21:46 ` Andreas Dilger
2019-10-01 7:51 ` harshad shirwadkar
2019-08-09 3:45 ` [PATCH v2 09/12] ext4: fast-commit commit range tracking Harshad Shirwadkar
2019-08-09 3:45 ` [PATCH v2 10/12] ext4: fast-commit commit path changes Harshad Shirwadkar
2019-08-09 3:45 ` [PATCH v2 11/12] ext4: fast-commit recovery " Harshad Shirwadkar
2019-08-09 3:45 ` [PATCH v2 12/12] docs: Add fast commit documentation Harshad Shirwadkar
2019-08-16 1:00 ` Darrick J. Wong
2019-08-20 6:38 ` harshad shirwadkar
2019-08-21 15:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812180106.GB28705@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).