From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jack@suse.cz, tytso@mit.edu, riteshh@linux.ibm.com
Subject: Re: [PATCH 2/5] ext4: move inode extension/truncate code out from ext4_iomap_end()
Date: Tue, 13 Aug 2019 20:46:18 +1000 [thread overview]
Message-ID: <20190813104616.GA4198@poseidon.bobrowski.net> (raw)
In-Reply-To: <20190812171839.GC24564@infradead.org>
On Mon, Aug 12, 2019 at 10:18:39AM -0700, Christoph Hellwig wrote:
> On Mon, Aug 12, 2019 at 10:52:53PM +1000, Matthew Bobrowski wrote:
> > In preparation for implementing the direct IO write code path modifications
> > that make us of iomap infrastructure we need to move out the inode
> > extension/truncate code from ext4_iomap_end() callback. For direct IO, if the
> > current code remained it would behave incorrectly. If we update the inode size
> > prior to converting unwritten extents we run the risk of allowing a racing
> > direct IO read operation to find unwritten extents before they are converted.
> >
> > The inode extension/truncate has been moved out into a new function
> > ext4_handle_inode_extension(). This will be used by both direct IO and DAX
> > code paths if the write results with the inode being extended.
>
> ext4_iomap_end is empty now, so you could as well remove it entirely.
As mentioned in my other email (4/5), this is callback needs to remain.
--M
next prev parent reply other threads:[~2019-08-13 10:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 12:52 [PATCH 0/5] ext4: direct IO via iomap infrastructure Matthew Bobrowski
2019-08-12 12:52 ` [PATCH 1/5] ext4: introduce direct IO read code path using " Matthew Bobrowski
2019-08-12 17:18 ` Christoph Hellwig
2019-08-12 20:17 ` Matthew Wilcox
2019-08-13 10:45 ` Matthew Bobrowski
2019-08-12 12:52 ` [PATCH 2/5] ext4: move inode extension/truncate code out from ext4_iomap_end() Matthew Bobrowski
2019-08-12 17:18 ` Christoph Hellwig
2019-08-13 10:46 ` Matthew Bobrowski [this message]
2019-08-28 19:59 ` Jan Kara
2019-08-28 21:54 ` Matthew Bobrowski
2019-08-29 8:18 ` Jan Kara
2019-08-12 12:53 ` [PATCH 3/5] iomap: modify ->end_io() calling convention Matthew Bobrowski
2019-08-12 17:18 ` Christoph Hellwig
2019-08-13 10:43 ` Matthew Bobrowski
2019-08-12 12:53 ` [PATCH 4/5] ext4: introduce direct IO write code path using iomap infrastructure Matthew Bobrowski
2019-08-12 17:04 ` RITESH HARJANI
2019-08-13 12:58 ` Matthew Bobrowski
2019-08-13 14:35 ` Darrick J. Wong
2019-08-14 9:51 ` Matthew Bobrowski
2019-08-12 17:34 ` Christoph Hellwig
2019-08-13 10:45 ` Matthew Bobrowski
2019-08-28 20:26 ` Jan Kara
2019-08-28 22:32 ` Dave Chinner
2019-08-29 8:03 ` Jan Kara
2019-08-29 11:47 ` Matthew Bobrowski
2019-08-29 11:45 ` Matthew Bobrowski
2019-08-29 12:38 ` Jan Kara
2019-08-12 12:53 ` [PATCH 5/5] ext4: clean up redundant buffer_head direct IO code Matthew Bobrowski
2019-08-12 17:31 ` [PATCH 0/5] ext4: direct IO via iomap infrastructure RITESH HARJANI
2019-08-13 11:10 ` Matthew Bobrowski
2019-08-13 12:27 ` RITESH HARJANI
2019-08-14 9:48 ` Matthew Bobrowski
2019-08-14 11:58 ` RITESH HARJANI
2019-08-21 13:14 ` Matthew Bobrowski
2019-08-22 12:00 ` Matthew Bobrowski
2019-08-22 14:11 ` Ritesh Harjani
2019-08-24 3:18 ` Matthew Bobrowski
2019-08-24 3:55 ` Darrick J. Wong
2019-08-24 23:04 ` Christoph Hellwig
2019-08-27 9:52 ` Matthew Bobrowski
2019-08-28 12:05 ` Matthew Bobrowski
2019-08-28 14:27 ` Theodore Y. Ts'o
2019-08-28 18:02 ` Jan Kara
2019-08-29 6:36 ` Christoph Hellwig
2019-08-29 11:20 ` Matthew Bobrowski
2019-08-29 14:41 ` Christoph Hellwig
2019-08-23 13:43 ` [RFC 1/1] ext4: PoC implementation of option-1 Ritesh Harjani
2019-08-23 13:49 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813104616.GA4198@poseidon.bobrowski.net \
--to=mbobrowski@mbobrowski.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).