From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FCDECE58D for ; Wed, 9 Oct 2019 09:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F10F2196E for ; Wed, 9 Oct 2019 09:18:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="QH1PLZwg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730347AbfJIJSj (ORCPT ); Wed, 9 Oct 2019 05:18:39 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40495 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbfJIJSj (ORCPT ); Wed, 9 Oct 2019 05:18:39 -0400 Received: by mail-pf1-f194.google.com with SMTP id x127so1222732pfb.7 for ; Wed, 09 Oct 2019 02:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dIMjgz2wkdOJUmFipmSdwtOA8NXSDN4ksobQ1Cu2hUA=; b=QH1PLZwggPZx3KtHORU9BFAiQwvFEibddbWy92hdfzkazAoK0ZRupqHaNi8+5J36OJ zP6038H7xR7gzG+jDff1hyaTp1CfcrtC+tsqwU7G0ifDfhuxrQguMX5vTqFwStKCeBiq NEyXvdnNeCOHyirKwJW1TZmZtt/wOeTngrkeCjHi5/xtBgwFjj6pwGptTzNKpd0/CLOt EmRbcL+dBJzZDfWeH8ki/Tw+8z6UN1/mJIAvc4YHJERfcLGIJwbzALFAZe3VH+S3Zq4X ENC1o4zhJM2+RRQqWQwm7eyb/0ZRCeUnusjirW/3aMTvwiFwuP6zXbnRlIFaGzN1/nae b8dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dIMjgz2wkdOJUmFipmSdwtOA8NXSDN4ksobQ1Cu2hUA=; b=N8Um4L7ycoZ6lkr6C/C9ex6/SzuG+xc3luZPcX8qOGabt+QJZc/T6b2zti6YHoikLp DP9HFyoLhqoPlVNO+KJgSo5GHk+FmEN4MpDScR/NiJQACY4DJ3zpdQo7keMB0tXhHhBj 4JBG7dwkqUxfLZoHiDcTlsLRqcHSkNjkIdWJar2w5rS/hNcGLsfoUVT2IbemgBV1nMAB QsR6G0+nRBRLc3FRebAeqNh6aahuWZjEQVkRSon0dbSPwH+97je9y8Mu+TlL9q5Pui+g 83CfR9HSv5HV52UhJLvFs3FwjQUJdqusl1t2qC4I7km5npSTLfVt1NwTMFhYqWzKqGGg izWw== X-Gm-Message-State: APjAAAUoc5x2uaj008FRSt1QcEvGsUMSLSfs52clZLWwMtoZysCvc7hn xyrVXegQrn3XSNxV2QO/0fAv0ZUKa2JD X-Google-Smtp-Source: APXvYqwmoyEVscGNMXHMxoyorGGNSGPQexKQNKFX+pBChZ4yWHcpoI8Ert7PG67/T1PhyKZrreUROw== X-Received: by 2002:a62:283:: with SMTP id 125mr2684628pfc.137.1570612718047; Wed, 09 Oct 2019 02:18:38 -0700 (PDT) Received: from poseidon.bobrowski.net ([114.78.226.167]) by smtp.gmail.com with ESMTPSA id h8sm2027979pfo.64.2019.10.09.02.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 02:18:37 -0700 (PDT) Date: Wed, 9 Oct 2019 20:18:31 +1100 From: Matthew Bobrowski To: Jan Kara Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v4 2/8] ext4: move out IOMAP_WRITE path into separate helper Message-ID: <20191009091830.GC2125@poseidon.bobrowski.net> References: <99b317af0f20a170fba2e70695d7cca1597fb19a.1570100361.git.mbobrowski@mbobrowski.org> <20191008103137.GE5078@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008103137.GE5078@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Oct 08, 2019 at 12:31:37PM +0200, Jan Kara wrote: > On Thu 03-10-19 21:33:29, Matthew Bobrowski wrote: > > In preparation for porting across the direct I/O path to iomap, split > > out the IOMAP_WRITE logic into a separate helper. This way, we don't > > need to clutter the ext4_iomap_begin() callback. > > > > Signed-off-by: Matthew Bobrowski > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara > > Just please reformat the comments to use full 80 column lines. Your Emacs > still doesn't seem to get it :) *nod* :) ----