Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Chengguang Xu <cgxu519@mykernel.net>
To: jack@suse.com
Cc: linux-ext4@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH] ext2: adjust block num when retry allocation
Date: Mon, 21 Oct 2019 07:23:26 +0800	[thread overview]
Message-ID: <20191020232326.84881-1-cgxu519@mykernel.net> (raw)

Set block num to original *count in a case
of retrying allocation in case num < *count

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
Hi Jan,

This patch is only compile-tested, I'm not sure if this
kind of unexpected condition which causes reallocation
will actually happen but baesd on the code the fix seems
correct and better.

 fs/ext2/balloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index e0cc55164505..924c1c765306 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -1404,6 +1404,7 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,
 		 * use.  So we may want to selectively mark some of the blocks
 		 * as free
 		 */
+		num = *count;
 		goto retry_alloc;
 	}
 
-- 
2.21.0




             reply	other threads:[~2019-10-20 23:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 23:23 Chengguang Xu [this message]
2019-10-21  9:18 ` [PATCH] ext2: adjust block num when retry allocation Jan Kara
2019-10-22  5:36   ` Chengguang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191020232326.84881-1-cgxu519@mykernel.net \
    --to=cgxu519@mykernel.net \
    --cc=jack@suse.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox